Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2978953003: Replace WEBRTC_TRACE logging in audio_device_alsa_linux.cc (Closed)

Created:
3 years, 5 months ago by saza WebRTC
Modified:
3 years, 5 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch set 1: Run a script to replace occurrences of WEBRTC_TRACE logging with the new style, on webrtc/modules/audio_device/linux/audio_device_alsa_linux.cc. Patch set 2: Manually fix log lines not handled by the script, remove unused header and variable. I would like to do this will the following files, too: webrtc/modules/audio_device/.. .../linux/audio_device_alsa_linux.cc .../linux/audio_device_pulse_linux.cc .../linux/audio_mixer_manager_alsa_linux.cc .../linux/audio_mixer_manager_pulse_linux.cc .../linux/latebindingsymboltable_linux.cc .../mac/audio_device_mac.cc .../mac/audio_mixer_manager_mac.cc .../win/audio_device_core_win.cc BUG=webrtc:5118 Review-Url: https://codereview.webrtc.org/2978953003 Cr-Commit-Position: refs/heads/master@{#19019} Committed: https://chromium.googlesource.com/external/webrtc/+/9b1367f2337d147ca7558ab11b7f2a510df12fd7

Patch Set 1 : script #

Patch Set 2 : manual fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -160 lines) Patch
M webrtc/modules/audio_device/linux/audio_device_alsa_linux.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_alsa_linux.cc View 1 53 chunks +102 lines, -158 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
saza WebRTC
ptal
3 years, 5 months ago (2017-07-14 11:38:33 UTC) #4
henrika_webrtc
Looks great. Was your plan to land this one first as is?
3 years, 5 months ago (2017-07-14 11:44:02 UTC) #5
saza WebRTC
On 2017/07/14 11:44:02, henrika_webrtc wrote: > Looks great. Was your plan to land this one ...
3 years, 5 months ago (2017-07-14 11:56:40 UTC) #6
henrika_webrtc
lgtm
3 years, 5 months ago (2017-07-14 11:57:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2978953003/20001
3 years, 5 months ago (2017-07-14 12:03:21 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 12:22:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/9b1367f2337d147ca7558ab11...

Powered by Google App Engine
This is Rietveld 408576698