Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2978863002:
Fix DetectNumberOfCores for 32-bit processes (Closed)
|
Created:
3 years, 5 months ago by brucedawson Modified:
3 years, 5 months ago Reviewers:
henrika_webrtc CC:
webrtc-reviews_webrtc.org, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix DetectNumberOfCores for 32-bit processes
GetSystemInfo will not return more than 32 for dwNumberOfProcessors when
called from a 32-bit process. This means that Chrome lies to me whenever
I enable logging. Calling GetNativeSystemInfo allows Chrome to return up
to 64 as the processor count. GetNativeSystemInfo even runs on WindowsXP
if that matters.
With the fix applied in a Chromium repo the logging at startup now says:
[320:196:712/335.515:INFO:cpu_info.cc(50)] Available number of cores: 48
BUG=webrtc:7981
Review-Url: https://codereview.webrtc.org/2978863002
Cr-Commit-Position: refs/heads/master@{#19008}
Committed: https://chromium.googlesource.com/external/webrtc/+/2178f700f6a375c67f4246e3492b09e34c551711
Patch Set 1 #
Messages
Total messages: 19 (15 generated)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Fix DetectNumberOfCores for 32-bit processes GetSystemInfo will not return more than 32 for dwNumberOfProcessors when called from a 32-bit process. This means that Chrome lies to me whenever I enable logging. Calling GetNativeSystemInfo allows Chrome to return up to 48 as the processor count. GetNativeSystemInfo even runs on WindowsXP if that matters. ========== to ========== Fix DetectNumberOfCores for 32-bit processes GetSystemInfo will not return more than 32 for dwNumberOfProcessors when called from a 32-bit process. This means that Chrome lies to me whenever I enable logging. Calling GetNativeSystemInfo allows Chrome to return up to 48 as the processor count. GetNativeSystemInfo even runs on WindowsXP if that matters. With the fix applied in a Chromium repo the logging at startup now ways: [320:196:712/335.515:INFO:cpu_info.cc(50)] Available number of cores: 48 ==========
brucedawson@chromium.org changed reviewers: + henrika@webrtc.org
Description was changed from ========== Fix DetectNumberOfCores for 32-bit processes GetSystemInfo will not return more than 32 for dwNumberOfProcessors when called from a 32-bit process. This means that Chrome lies to me whenever I enable logging. Calling GetNativeSystemInfo allows Chrome to return up to 48 as the processor count. GetNativeSystemInfo even runs on WindowsXP if that matters. With the fix applied in a Chromium repo the logging at startup now ways: [320:196:712/335.515:INFO:cpu_info.cc(50)] Available number of cores: 48 ========== to ========== Fix DetectNumberOfCores for 32-bit processes GetSystemInfo will not return more than 32 for dwNumberOfProcessors when called from a 32-bit process. This means that Chrome lies to me whenever I enable logging. Calling GetNativeSystemInfo allows Chrome to return up to 64 as the processor count. GetNativeSystemInfo even runs on WindowsXP if that matters. With the fix applied in a Chromium repo the logging at startup now ways: [320:196:712/335.515:INFO:cpu_info.cc(50)] Available number of cores: 48 ==========
Minor fix. PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19227)
Description was changed from ========== Fix DetectNumberOfCores for 32-bit processes GetSystemInfo will not return more than 32 for dwNumberOfProcessors when called from a 32-bit process. This means that Chrome lies to me whenever I enable logging. Calling GetNativeSystemInfo allows Chrome to return up to 64 as the processor count. GetNativeSystemInfo even runs on WindowsXP if that matters. With the fix applied in a Chromium repo the logging at startup now ways: [320:196:712/335.515:INFO:cpu_info.cc(50)] Available number of cores: 48 ========== to ========== Fix DetectNumberOfCores for 32-bit processes GetSystemInfo will not return more than 32 for dwNumberOfProcessors when called from a 32-bit process. This means that Chrome lies to me whenever I enable logging. Calling GetNativeSystemInfo allows Chrome to return up to 64 as the processor count. GetNativeSystemInfo even runs on WindowsXP if that matters. With the fix applied in a Chromium repo the logging at startup now says: [320:196:712/335.515:INFO:cpu_info.cc(50)] Available number of cores: 48 BUG=webrtc:7981 ==========
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks for improving the code ;-) lgtm
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1499965358386820, "parent_rev":
"c26dd6c8bd2c67f0a6c336356092832cd7ac722e", "commit_rev":
"2178f700f6a375c67f4246e3492b09e34c551711"}
Message was sent while issue was closed.
Description was changed from ========== Fix DetectNumberOfCores for 32-bit processes GetSystemInfo will not return more than 32 for dwNumberOfProcessors when called from a 32-bit process. This means that Chrome lies to me whenever I enable logging. Calling GetNativeSystemInfo allows Chrome to return up to 64 as the processor count. GetNativeSystemInfo even runs on WindowsXP if that matters. With the fix applied in a Chromium repo the logging at startup now says: [320:196:712/335.515:INFO:cpu_info.cc(50)] Available number of cores: 48 BUG=webrtc:7981 ========== to ========== Fix DetectNumberOfCores for 32-bit processes GetSystemInfo will not return more than 32 for dwNumberOfProcessors when called from a 32-bit process. This means that Chrome lies to me whenever I enable logging. Calling GetNativeSystemInfo allows Chrome to return up to 64 as the processor count. GetNativeSystemInfo even runs on WindowsXP if that matters. With the fix applied in a Chromium repo the logging at startup now says: [320:196:712/335.515:INFO:cpu_info.cc(50)] Available number of cores: 48 BUG=webrtc:7981 Review-Url: https://codereview.webrtc.org/2978863002 Cr-Commit-Position: refs/heads/master@{#19008} Committed: https://chromium.googlesource.com/external/webrtc/+/2178f700f6a375c67f4246e34... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/2178f700f6a375c67f4246e34... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
