Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2978643002: Removing bad-continuation param and fixing resulting errors. Fixed indentation errors, in telemetry… (Closed)

Created:
3 years, 5 months ago by Lo-Lo
Modified:
3 years, 5 months ago
Reviewers:
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Removing bad-continuation param and fixing resulting errors. Fixed indentation errors, in telemetry.internal.actions.drag , telemetry.decorators , telemetry.internal.actions.drag_unittest , telemetry.internal.actions.key_event_unittest , telemetry.internal.actions.navigate , telemetry.core.tracing_controller_unittest Removing bad-continuation param and fixing resulting errors. Fixed indentation errors, in build.update_docs, telemetry.core.android_action_runner_unittest , telemetry.core.network_controller , telemetry.core.memory_cache_http_server_unittest Removing bad-continuation param and fixing resulting errors. Fixed indentation errors, in telemetry.__init__ , telemetry.benchmark_runner_unittest , telemetry.benchmark_run_unittest , telemetry.benchmark , telemetry.benchmark_runner BUG=catapult:#3604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -60 lines) Patch
M telemetry/build/update_docs.py View 2 chunks +4 lines, -4 lines 0 comments Download
M telemetry/pylintrc View 1 chunk +0 lines, -4 lines 0 comments Download
M telemetry/telemetry/__init__.py View 1 chunk +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/benchmark.py View 1 chunk +2 lines, -4 lines 0 comments Download
M telemetry/telemetry/benchmark_run_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M telemetry/telemetry/benchmark_runner.py View 5 chunks +15 lines, -19 lines 0 comments Download
M telemetry/telemetry/benchmark_runner_unittest.py View 4 chunks +6 lines, -6 lines 0 comments Download
M telemetry/telemetry/core/android_action_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/core/memory_cache_http_server_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M telemetry/telemetry/core/network_controller.py View 1 chunk +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/core/tracing_controller_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/decorators.py View 2 chunks +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/actions/drag.py View 1 chunk +6 lines, -6 lines 0 comments Download
M telemetry/telemetry/internal/actions/drag_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/actions/key_event_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/actions/navigate.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (4 generated)
Lo-Lo
The CQ bit was checked by loloangela@google.com to run a CQ dry run
3 years, 5 months ago (2017-07-11 15:16:08 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2978643002/1
3 years, 5 months ago (2017-07-11 15:16:15 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 5 months ago (2017-07-11 15:19:45 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 15:19:46 UTC) #4
Dry run: Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

Powered by Google App Engine
This is Rietveld 408576698