Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2978623002: Implement H264 codec in Objective-C classes. (Closed)

Created:
3 years, 5 months ago by andersc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Implement H264 codec in Objective-C classes. Continues the work in https://codereview.webrtc.org/2966023002 but moves the code in VideoToolbox/encoder and decoder into the RTCVideoEncoder/Decoder Obj-C classes directly, removing one layer of indirection. Before the RTCVideoEncoder was only a thin wrapper around the C++ code. The code in VideoToolbox/ is now mostly implemented in Obj-C style. Also contains some general fixes for injectable video codecs that were discovered along the way. BUG=webrtc:7924

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase and minor style fixes. #

Patch Set 4 : Oops, fix compile error. #

Patch Set 5 : Fix nullability in callback and gn check on Mac. #

Patch Set 6 : Make sure callback has correct types. #

Patch Set 7 : Make it even more sure. #

Patch Set 8 : Fix test after rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1224 lines, -2097 lines) Patch
M webrtc/modules/video_coding/BUILD.gn View 1 2 3 4 3 chunks +37 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
A webrtc/modules/video_coding/codecs/test/objc_codec_h264_test.h View 1 chunk +45 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/codecs/test/objc_codec_h264_test.mm View 1 chunk +41 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 2 chunks +13 lines, -5 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 1 2 8 chunks +13 lines, -13 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCEncodedImage.mm View 1 1 chunk +0 lines, -74 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCRtpFragmentationHeader.mm View 1 1 chunk +0 lines, -61 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm View 1 1 chunk +0 lines, -114 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec+Private.h View 1 1 chunk +0 lines, -57 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm View 1 2 1 chunk +0 lines, -262 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoFrame.mm View 1 1 chunk +0 lines, -139 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/PeerConnection/objc_video_encoder_factory.mm View 1 2 3 4 5 6 5 chunks +17 lines, -12 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/Video/RTCEncodedImage.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/Video/RTCRtpFragmentationHeader.mm View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/Video/RTCVideoCodec.mm View 1 3 chunks +3 lines, -0 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/Video/RTCVideoCodec+Private.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/Video/RTCVideoFrame.mm View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoCodecH264.mm View 1 2 3 1 chunk +106 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm View 1 1 chunk +251 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm View 1 2 3 4 5 6 7 1 chunk +542 lines, -0 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/VideoToolbox/decoder.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/VideoToolbox/decoder.mm View 1 1 chunk +0 lines, -277 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.h View 1 1 chunk +0 lines, -97 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm View 1 1 chunk +0 lines, -765 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/VideoToolbox/helpers.h View 1 chunk +47 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/VideoToolbox/helpers.cc View 1 1 chunk +90 lines, -0 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/VideoToolbox/videocodecfactory.h View 1 chunk +0 lines, -52 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/VideoToolbox/videocodecfactory.mm View 1 1 chunk +0 lines, -106 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h View 1 2 5 chunks +19 lines, -5 lines 0 comments Download
M webrtc/sdk/objc/Framework/UnitTests/objc_video_encoder_factory_tests.mm View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 35 (34 generated)
andersc
3 years, 4 months ago (2017-08-15 07:30:23 UTC) #35
This CL has been superseded by https://codereview.webrtc.org/2987413002/

Powered by Google App Engine
This is Rietveld 408576698