Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2978573002: Don't call CreateDtlsTransport_n from non-network thread in WebRtcSession (Closed)

Created:
3 years, 5 months ago by Taylor Brandstetter
Modified:
3 years, 5 months ago
Reviewers:
pthatcher, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't call CreateDtlsTransport_n from non-network thread in WebRtcSession I'm not sure if it's possible to hit this code any more, but better safe than sorry. BUG=webrtc:7714 TBR=pthatcher@webrtc.org Review-Url: https://codereview.webrtc.org/2978573002 Cr-Commit-Position: refs/heads/master@{#18960} Committed: https://chromium.googlesource.com/external/webrtc/+/d8cf08f1663c195cc4ed7ba60b3fa6cfec82e091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/pc/webrtcsession.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
Taylor Brandstetter
Another trivial bug fix
3 years, 5 months ago (2017-07-11 02:34:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2978573002/1
3 years, 5 months ago (2017-07-11 02:34:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/d8cf08f1663c195cc4ed7ba60b3fa6cfec82e091
3 years, 5 months ago (2017-07-11 03:07:04 UTC) #8
pthatcher
3 years, 5 months ago (2017-07-11 05:27:01 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698