Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2978173002: Fix fullscreen scaling in AppRTCMobile. (Closed)

Created:
3 years, 5 months ago by sakal
Modified:
3 years, 5 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix fullscreen scaling in AppRTCMobile. The surface view renderer size was set to match parent so it couldn't adjust based on the frame size. The size is now set to wrap_content which allows the renderer to adjust. The root element of the call activity is changed to FrameLayout to allow the renderer to center. requestLayout is added to SurfaceView setScalingType so onMeasure gets called again. BUG=webrtc:7901 Review-Url: https://codereview.webrtc.org/2978173002 Cr-Commit-Position: refs/heads/master@{#19073} Committed: https://chromium.googlesource.com/external/webrtc/+/fcf97c3b75f9f6719d3fb833a8fe95b33a444859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M webrtc/examples/androidapp/res/layout/activity_call.xml View 2 chunks +12 lines, -4 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
sakal
PTAL
3 years, 5 months ago (2017-07-18 10:19:41 UTC) #3
kthelgason
lgtm
3 years, 5 months ago (2017-07-18 11:23:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2978173002/1
3 years, 5 months ago (2017-07-18 11:24:37 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-07-18 12:01:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fcf97c3b75f9f6719d3fb833a...

Powered by Google App Engine
This is Rietveld 408576698