Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2977533002: Prevent warnings in PacketRouterTest and PacketRouterRembTest (Closed)

Created:
3 years, 5 months ago by eladalon
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Prevent warnings in PacketRouterTest and PacketRouterRembTest Change MockRtpRtcp to NiceMock<MockRtpRtcp> throughout PacketRouterTest and PacketRouterRembTest (12 tests in total), to suppress a large number of warnings which are currently ignored. BUG=None Review-Url: https://codereview.webrtc.org/2977533002 Cr-Commit-Position: refs/heads/master@{#18946} Committed: https://chromium.googlesource.com/external/webrtc/+/6c9556e7f19bddbb38fadf22fd3b52672d0f59ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M webrtc/modules/pacing/packet_router_unittest.cc View 11 chunks +16 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
eladalon
PTAL
3 years, 5 months ago (2017-07-10 09:41:20 UTC) #2
philipel
lgtm
3 years, 5 months ago (2017-07-10 09:48:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2977533002/1
3 years, 5 months ago (2017-07-10 10:05:28 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 10:33:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/6c9556e7f19bddbb38fadf22f...

Powered by Google App Engine
This is Rietveld 408576698