Increase the size of the buffer for type.name.id.

Increase the size of the buffer for type.name.id.

BUG=chromium:653087
Review-Url: https://codereview.webrtc.org/2977363002
Cr-Commit-Position: refs/heads/master@{#19072}
Committed: https://chromium.googlesource.com/external/webrtc/+/b0b721a68c2d90f5b6476c01cff0d4298d58c08a

[ehmaldonado_webrtc, 2017-07-18 10:45:17]

ehmaldonado@webrtc.org changed reviewers:
+ hbos@webrtc.org, tommi@webrtc.org

[hbos, 2017-07-18 10:55:52]

lgtm

[ehmaldonado_webrtc, 2017-07-18 10:57:29]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2017-07-18 10:57:37]

The CQ bit was unchecked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-07-18 10:57:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2017-07-18 11:09:54]

On 2017/07/18 10:55:52, hbos wrote:
> lgtm

Can you make a CL to enable the tracing in rtcstats_integrationtest.cc and/or
rtcstatscollector_unittest.cc so that this is covered by testing?

[tommi, 2017-07-18 11:22:56]

It would be great to have a test for this as well, like hbos suggests

https://codereview.webrtc.org/2977363002/diff/1/webrtc/pc/rtcstatscollector.cc
File webrtc/pc/rtcstatscollector.cc (right):

https://codereview.webrtc.org/2977363002/diff/1/webrtc/pc/rtcstatscollector.c...
webrtc/pc/rtcstatscollector.cc:35: const int kStatTypeMemberNameAndIdMaxLen =
512;
Let's go for 1024. The size doesn't matter that much since we're allocating on
the stack.

[tommi, 2017-07-18 11:23:10]

On 2017/07/18 11:22:56, tommi (wëbrtc) wrote:
> It would be great to have a test for this as well, like hbos suggests
> 
> https://codereview.webrtc.org/2977363002/diff/1/webrtc/pc/rtcstatscollector.cc
> File webrtc/pc/rtcstatscollector.cc (right):
> 
>
https://codereview.webrtc.org/2977363002/diff/1/webrtc/pc/rtcstatscollector.c...
> webrtc/pc/rtcstatscollector.cc:35: const int kStatTypeMemberNameAndIdMaxLen =
> 512;
> Let's go for 1024. The size doesn't matter that much since we're allocating on
> the stack.

and lgtm with that :)

[tommi, 2017-07-18 11:23:12]

On 2017/07/18 11:22:56, tommi (wëbrtc) wrote:
> It would be great to have a test for this as well, like hbos suggests
> 
> https://codereview.webrtc.org/2977363002/diff/1/webrtc/pc/rtcstatscollector.cc
> File webrtc/pc/rtcstatscollector.cc (right):
> 
>
https://codereview.webrtc.org/2977363002/diff/1/webrtc/pc/rtcstatscollector.c...
> webrtc/pc/rtcstatscollector.cc:35: const int kStatTypeMemberNameAndIdMaxLen =
> 512;
> Let's go for 1024. The size doesn't matter that much since we're allocating on
> the stack.

and lgtm with that :)

[commit-bot: I haz the power, 2017-07-18 11:27:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1500375449882310, "parent_rev":
"43a85f03435f92306e3626fdc00352bbdd0d21a0", "commit_rev":
"b0b721a68c2d90f5b6476c01cff0d4298d58c08a"}

[commit-bot: I haz the power, 2017-07-18 11:27:13]

Description was changed from

==========
Increase the size of the buffer for type.name.id.

BUG=chromium:653087
==========

to

==========
Increase the size of the buffer for type.name.id.

BUG=chromium:653087

Review-Url: https://codereview.webrtc.org/2977363002
Cr-Commit-Position: refs/heads/master@{#19072}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b0b721a68c2d90f5b6476c01c...
==========

[commit-bot: I haz the power, 2017-07-18 11:27:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b0b721a68c2d90f5b6476c01c...

[ehmaldonado_webrtc, 2017-07-18 11:39:08]

On 2017/07/18 11:22:56, tommi (wëbrtc) wrote:
> It would be great to have a test for this as well, like hbos suggests
> 
> https://codereview.webrtc.org/2977363002/diff/1/webrtc/pc/rtcstatscollector.cc
> File webrtc/pc/rtcstatscollector.cc (right):
> 
>
https://codereview.webrtc.org/2977363002/diff/1/webrtc/pc/rtcstatscollector.c...
> webrtc/pc/rtcstatscollector.cc:35: const int kStatTypeMemberNameAndIdMaxLen =
> 512;
> Let's go for 1024. The size doesn't matter that much since we're allocating on
> the stack.

Working on it on https://codereview.webrtc.org/2979203002