Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2976983002:
iOS AppRTCMobile: Close peerconnection when disconnecting (Closed)
|
Created:
3 years, 5 months ago by magjed_webrtc Modified:
3 years, 5 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptioniOS AppRTCMobile: Close peerconnection when disconnecting
We currently don't close the peerconnection before deallocing. That
could potentially cause race conditions if it's still being processed on
other threads.
BUG=webrtc:7976
Review-Url: https://codereview.webrtc.org/2976983002
Cr-Commit-Position: refs/heads/master@{#19121}
Committed: https://chromium.googlesource.com/external/webrtc/+/cc8b906467af788747812f9908809f2e91e123a7
Patch Set 1 #
Messages
Total messages: 21 (13 generated)
The CQ bit was checked by magjed@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== iOS AppRTCMobile: Close peerconnection during shutdown We currently don't close the peerconnection before deallocing. That could potentially cause race conditions if it's still being processed on other threads. BUG=webrtc:7976 ========== to ========== iOS AppRTCMobile: Close peerconnection during shutdown We currently don't close the peerconnection before deallocing. That could potentially cause race conditions if it's still being processed on other threads. BUG=webrtc:7976 ==========
magjed@webrtc.org changed reviewers: + tserng@amazon.com
Description was changed from ========== iOS AppRTCMobile: Close peerconnection during shutdown We currently don't close the peerconnection before deallocing. That could potentially cause race conditions if it's still being processed on other threads. BUG=webrtc:7976 ========== to ========== iOS AppRTCMobile: Close peerconnection when disconnecting We currently don't close the peerconnection before deallocing. That could potentially cause race conditions if it's still being processed on other threads. BUG=webrtc:7976 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please take a look.
On 2017/07/13 at 09:38:04, magjed wrote: > Please take a look. lgtm
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
magjed@webrtc.org changed reviewers: + denicija@webrtc.org
Daniela - can you review as well?
LGTM
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1500905144213850, "parent_rev":
"e029d99f19dbb13c962d6fe4ceadf6f461aeaccf", "commit_rev":
"cc8b906467af788747812f9908809f2e91e123a7"}
Message was sent while issue was closed.
Description was changed from ========== iOS AppRTCMobile: Close peerconnection when disconnecting We currently don't close the peerconnection before deallocing. That could potentially cause race conditions if it's still being processed on other threads. BUG=webrtc:7976 ========== to ========== iOS AppRTCMobile: Close peerconnection when disconnecting We currently don't close the peerconnection before deallocing. That could potentially cause race conditions if it's still being processed on other threads. BUG=webrtc:7976 Review-Url: https://codereview.webrtc.org/2976983002 Cr-Commit-Position: refs/heads/master@{#19121} Committed: https://chromium.googlesource.com/external/webrtc/+/cc8b906467af788747812f990... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/cc8b906467af788747812f990... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
