Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2975613002:
Adjust for initial cropping when adapting frame. (Closed)
|
Created:
3 years, 5 months ago by andersc Modified:
3 years, 3 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdjust for initial cropping when adapting frame.
When adapting a frame, any initial cropping coordinate was replaced
by the coordinate calculated for adapting. Offset initial coordinate
instead.
BUG=webrtc:7880
Review-Url: https://codereview.webrtc.org/2975613002
Cr-Commit-Position: refs/heads/master@{#19509}
Committed: https://chromium.googlesource.com/external/webrtc/+/151aa6b3f7b00c9be05ffda848bc42748af19f04
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #
Messages
Total messages: 30 (24 generated)
The CQ bit was checked by andersc@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Adjust for initial cropping when adapting frame. When adapting a frame, any initial cropping coordinate was replaced by the coordinate calculated for adapting. Offset initial coordinate instead. BUG=webrtc:7880 ========== to ========== Adjust for initial cropping when adapting frame. When adapting a frame, any initial cropping coordinate was replaced by the coordinate calculated for adapting. Offset initial coordinate instead. BUG=webrtc:7880 ==========
andersc@webrtc.org changed reviewers: + magjed@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Oops, I realized I never sent out an email for this CL.
lgtm
The CQ bit was checked by andersc@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_api_framework on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)
The CQ bit was checked by andersc@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_api_framework on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)
The CQ bit was checked by andersc@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/11813)
The CQ bit was checked by andersc@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by andersc@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org Link to the patchset: https://codereview.webrtc.org/2975613002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1503649865040190,
"parent_rev": "8b07305b048fb91840ae7f9a58c6df7115540015", "commit_rev":
"151aa6b3f7b00c9be05ffda848bc42748af19f04"}
Message was sent while issue was closed.
Description was changed from ========== Adjust for initial cropping when adapting frame. When adapting a frame, any initial cropping coordinate was replaced by the coordinate calculated for adapting. Offset initial coordinate instead. BUG=webrtc:7880 ========== to ========== Adjust for initial cropping when adapting frame. When adapting a frame, any initial cropping coordinate was replaced by the coordinate calculated for adapting. Offset initial coordinate instead. BUG=webrtc:7880 Review-Url: https://codereview.webrtc.org/2975613002 Cr-Commit-Position: refs/heads/master@{#19509} Committed: https://chromium.googlesource.com/external/webrtc/+/151aa6b3f7b00c9be05ffda84... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/151aa6b3f7b00c9be05ffda84... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
