Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2975383002: Fix incorrect DCHECK in generic_decoder.cc. (Closed)

Created:
3 years, 5 months ago by tommi
Modified:
3 years, 5 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix incorrect DCHECK in generic_decoder.cc. When ownership is not external, the decoder pointer should be valid. BUG=b/63658384 TBR=magjed@webrtc.org Review-Url: https://codereview.webrtc.org/2975383002 Cr-Commit-Position: refs/heads/master@{#19041} Committed: https://chromium.googlesource.com/external/webrtc/+/058aa719ff877e091900f8a748f6835dd4b7d0bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/video_coding/generic_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
tommi
3 years, 5 months ago (2017-07-15 11:37:06 UTC) #4
tommi
tbr-ing to unblock and due to ooo
3 years, 5 months ago (2017-07-15 18:30:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2975383002/1
3 years, 5 months ago (2017-07-15 18:30:54 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-15 18:33:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/058aa719ff877e091900f8a74...

Powered by Google App Engine
This is Rietveld 408576698