Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2975103002:
Fix http://crbug.com/741252 (Closed)
DescriptionFix http://crbug.com/741252
The root cause is when a DxgiContext is reseted, it has not been correctly
cleared from DxgiOutputDuplicator. So during next CaptureFrame() function call,
DxgiOutputDuplicator will spread the context change to a deleted instance.
BUG=741252
Review-Url: https://codereview.webrtc.org/2975103002
Cr-Commit-Position: refs/heads/master@{#18992}
Committed: https://chromium.googlesource.com/external/webrtc/+/67e438ffe5043efaef1ab844e7504e952dd76072
Patch Set 1 #
Messages
Total messages: 25 (18 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix http://crbug.com/741252 The root cause is when a DxgiContext is reseted, it has not been correctly cleared from DxgiOutputDuplicator. So during next CaptureFrame() function call, DxgiOutputDuplicator will spread the context change to a deleted instance. BUG=741252 ========== to ========== Fix http://crbug.com/741252 The root cause is when a DxgiContext is reseted, it has not been correctly cleared from DxgiOutputDuplicator. So during next CaptureFrame() function call, DxgiOutputDuplicator will spread the context change to a deleted instance. BUG=741252 ==========
zijiehe@chromium.org changed reviewers: + sergeyu@chromium.org
sergeyu@google.com changed reviewers: + sergeyu@google.com
lgtm
The CQ bit was checked by zijiehe@chromium.org
The CQ bit was unchecked by zijiehe@chromium.org
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19221)
sergeyu@chromium.org changed reviewers: - sergeyu@google.com
lgtm
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499905577525530,
"parent_rev": "7b0c6fa2743ee79f080723aed2d9bea3a8325313", "commit_rev":
"67e438ffe5043efaef1ab844e7504e952dd76072"}
Message was sent while issue was closed.
Description was changed from ========== Fix http://crbug.com/741252 The root cause is when a DxgiContext is reseted, it has not been correctly cleared from DxgiOutputDuplicator. So during next CaptureFrame() function call, DxgiOutputDuplicator will spread the context change to a deleted instance. BUG=741252 ========== to ========== Fix http://crbug.com/741252 The root cause is when a DxgiContext is reseted, it has not been correctly cleared from DxgiOutputDuplicator. So during next CaptureFrame() function call, DxgiOutputDuplicator will spread the context change to a deleted instance. BUG=741252 Review-Url: https://codereview.webrtc.org/2975103002 Cr-Commit-Position: refs/heads/master@{#18992} Committed: https://chromium.googlesource.com/external/webrtc/+/67e438ffe5043efaef1ab844e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/67e438ffe5043efaef1ab844e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
