Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2975043002: Remove internal buffer memory check in AEC module (Closed)

Created:
3 years, 5 months ago by saza WebRTC
Modified:
3 years, 5 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removes internal buffer memory check in AEC module. The check triggered in 30 / 1000 cases of running PeerConnectionIntegrationTest.CallTransferredForCaller locally, far more often than expected. It will soon be replaced by more graceful handling. BUG=webrtc:7845 Review-Url: https://codereview.webrtc.org/2975043002 Cr-Commit-Position: refs/heads/master@{#18983} Committed: https://chromium.googlesource.com/external/webrtc/+/10b0d0367346419cce329a4a4ba198e22a4d7015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
saza WebRTC
ptal
3 years, 5 months ago (2017-07-12 07:01:15 UTC) #3
peah-webrtc
On 2017/07/12 07:01:15, Sam Zackrisson WebRTC wrote: > ptal lgtm!
3 years, 5 months ago (2017-07-12 07:02:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2975043002/1
3 years, 5 months ago (2017-07-12 07:05:44 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 07:29:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/10b0d0367346419cce329a4a4...

Powered by Google App Engine
This is Rietveld 408576698