Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2974903003: Make BaseChannel::rtp_transport_ a unique_ptr. (Closed)

Created:
3 years, 5 months ago by Zach Stein
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make BaseChannel::rtp_transport_ a unique_ptr. This will eventually be a unique_ptr<RtpTransportInternal> so that we can choose to use an RtpTransport or SrtpTransport. BUG=None Review-Url: https://codereview.webrtc.org/2974903003 Cr-Commit-Position: refs/heads/master@{#18987} Committed: https://chromium.googlesource.com/external/webrtc/+/e8ab5435893b7d59959e7cbd8f56493457b32757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Patch
M webrtc/pc/channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/channel.cc View 16 chunks +30 lines, -29 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Zach Stein
Trying to break up my SrtpTransport work in to simpler changes.
3 years, 5 months ago (2017-07-11 22:14:12 UTC) #2
Taylor Brandstetter
lgtm
3 years, 5 months ago (2017-07-12 15:30:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2974903003/1
3 years, 5 months ago (2017-07-12 15:31:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, build has not started yet; ...
3 years, 5 months ago (2017-07-12 17:31:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2974903003/1
3 years, 5 months ago (2017-07-12 17:50:14 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 18:49:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e8ab5435893b7d59959e7cbd8...

Powered by Google App Engine
This is Rietveld 408576698