Robustification of the AEC3 echo removal in the first part of the call

Robustification of the AEC3 echo removal in the first part of the call

This CL robustifies the echo removal in AEC3 during the initial parts
of a call in two ways:
-By extending the period until which a headset is deemed to be used.
-By increasing the assumed echo path gain for unknown echo paths at
higher frequencies.


BUG=webrtc:7971
Review-Url: https://codereview.webrtc.org/2974883002
Cr-Commit-Position: refs/heads/master@{#18967}
Committed: https://chromium.googlesource.com/external/webrtc/+/5e6685ff3584c3990febd040359cd9258fc3fa74

[peah-webrtc, 2017-07-11 06:31:57]

peah@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[peah-webrtc, 2017-07-11 06:31:58]

Hi ivoc@
Could you please take a look at this CL?

[ivoc, 2017-07-11 08:46:05]

lgtm, see one question below.

https://codereview.webrtc.org/2974883002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec3/residual_echo_estimator.cc (right):

https://codereview.webrtc.org/2974883002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec3/residual_echo_estimator.cc:180: const
AecState& aec_state,
Since the function only uses aec_state.HeadsetDetected(), how about passing that
in as an argument as a bool instead of the aec_state?

[peah-webrtc, 2017-07-11 08:53:01]

Thanks for the review!
I've uploaded a new patch set with the suggested changes.

https://codereview.webrtc.org/2974883002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec3/residual_echo_estimator.cc (right):

https://codereview.webrtc.org/2974883002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec3/residual_echo_estimator.cc:180: const
AecState& aec_state,
On 2017/07/11 08:46:04, ivoc wrote:
> Since the function only uses aec_state.HeadsetDetected(), how about passing
that
> in as an argument as a bool instead of the aec_state? 

Good point!

Done.

[peah-webrtc, 2017-07-11 10:26:14]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2017-07-11 10:26:14]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2974883002/#ps40001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-07-11 10:26:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-11 11:19:59]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499768774399360,
"parent_rev": "c1abde7e8eaaa9d458459d84f696b312a33fcdd3", "commit_rev":
"5e6685ff3584c3990febd040359cd9258fc3fa74"}

[commit-bot: I haz the power, 2017-07-11 11:20:03]

Description was changed from

==========
Robustification of the AEC3 echo removal in the first part of the call

This CL robustifies the echo removal in AEC3 during the initial parts
of a call in two ways:
-By extending the period until which a headset is deemed to be used.
-By increasing the assumed echo path gain for unknown echo paths at
higher frequencies.


BUG=webrtc:7971
==========

to

==========
Robustification of the AEC3 echo removal in the first part of the call

This CL robustifies the echo removal in AEC3 during the initial parts
of a call in two ways:
-By extending the period until which a headset is deemed to be used.
-By increasing the assumed echo path gain for unknown echo paths at
higher frequencies.


BUG=webrtc:7971

Review-Url: https://codereview.webrtc.org/2974883002
Cr-Commit-Position: refs/heads/master@{#18967}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5e6685ff3584c3990febd0403...
==========

[commit-bot: I haz the power, 2017-07-11 11:20:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/5e6685ff3584c3990febd0403...