Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2974863003: Use relative paths in GN files. (Closed)

Created:
3 years, 5 months ago by jianjunz
Modified:
3 years, 5 months ago
Reviewers:
ehmaldonado_webrtc
CC:
aleloi, AleBzk, aluebs-webrtc, Andrew MacDonald, audio-team_agora.io, bjornv1, danilchap, hlundin-webrtc, henrika_webrtc, kwiberg-webrtc, mflodman, minyue-webrtc, niklas.enbom, peah-webrtc, perkj_webrtc, qiang.lu, sdk-team_agora.io, the sun, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, video-team_agora.io, webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhengzhonghou_agora.io, zhuangzesen_agora.io
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use relative paths in GN files. BUG=webrtc:7952 TBR=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2974863003 Cr-Commit-Position: refs/heads/master@{#18970} Committed: https://chromium.googlesource.com/external/webrtc/+/c024740b5ede39ecb82fdb9dbc734648974c998a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -334 lines) Patch
M webrtc/BUILD.gn View 4 chunks +18 lines, -18 lines 0 comments Download
M webrtc/api/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/audio/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/call/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/common_video/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/BUILD.gn View 16 chunks +58 lines, -55 lines 0 comments Download
M webrtc/media/BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/modules/BUILD.gn View 3 chunks +104 lines, -104 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_mixer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/py_quality_assessment/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/bitrate_controller/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/media_file/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/pacing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 3 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/video_processing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/pc/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/rtc_tools/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/rtc_tools/network_tester/BUILD.gn View 5 chunks +8 lines, -8 lines 0 comments Download
M webrtc/sdk/android/BUILD.gn View 14 chunks +55 lines, -55 lines 0 comments Download
M webrtc/test/BUILD.gn View 2 chunks +8 lines, -8 lines 0 comments Download
M webrtc/video/BUILD.gn View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 3 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
jianjunz
PTAL, thanks.
3 years, 5 months ago (2017-07-11 06:56:34 UTC) #4
ehmaldonado_webrtc
On 2017/07/11 06:56:34, jianjunz wrote: > PTAL, thanks. lgtm thanks!
3 years, 5 months ago (2017-07-11 12:31:21 UTC) #9
jianjunz
On 2017/07/11 at 12:31:21, ehmaldonado wrote: > On 2017/07/11 06:56:34, jianjunz wrote: > > PTAL, ...
3 years, 5 months ago (2017-07-11 13:06:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2974863003/1
3 years, 5 months ago (2017-07-11 13:07:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19129)
3 years, 5 months ago (2017-07-11 13:13:10 UTC) #14
ehmaldonado_webrtc
On 2017/07/11 13:13:10, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 5 months ago (2017-07-11 13:17:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2974863003/1
3 years, 5 months ago (2017-07-11 13:17:48 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/c024740b5ede39ecb82fdb9dbc734648974c998a
3 years, 5 months ago (2017-07-11 13:20:51 UTC) #22
jianjunz
3 years, 5 months ago (2017-07-11 14:16:40 UTC) #23
Message was sent while issue was closed. 
On 2017/07/11 13:17:00, ehmaldonado_webrtc wrote:
> On 2017/07/11 13:13:10, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   presubmit on master.tryserver.webrtc (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/19129)
> 
> I'll TBR kjellander@ for these changes.

Sure, it changed a lot of files.

Powered by Google App Engine
This is Rietveld 408576698