Chromium Code Reviews

Unified Diff: webrtc/modules/audio_coding/BUILD.gn

Issue 2973613002: Moving asm code out of isac_fix_c sources list (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/BUILD.gn
diff --git a/webrtc/modules/audio_coding/BUILD.gn b/webrtc/modules/audio_coding/BUILD.gn
index ce775dc077c2cdcf831ed9a9b699cc3ed09f32f2..e805bcb294bf597a27bad3afcfd054629421d03c 100644
--- a/webrtc/modules/audio_coding/BUILD.gn
+++ b/webrtc/modules/audio_coding/BUILD.gn
@@ -634,6 +634,16 @@ rtc_source_set("isac_fix_common") {
public_configs = [ ":isac_fix_config" ]
}
+rtc_source_set("isac_fix_c_asm") {
ehmaldonado_webrtc 2017/07/05 15:31:18 Why is the suffix _asm here, and _arm_asm in https
mbonadei 2017/07/06 09:45:59 Thanks for spotting this. I changed this to _arm_a
+ sources = []
+ if (current_cpu == "arm" && arm_version >= 7) {
+ sources += [
+ "codecs/isac/fix/source/lattice_armv7.S",
+ "codecs/isac/fix/source/pitch_filter_armv6.S",
+ ]
+ }
+}
+
rtc_source_set("isac_fix_c") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [
@@ -702,14 +712,11 @@ rtc_source_set("isac_fix_c") {
}
if (current_cpu == "arm" && arm_version >= 7) {
- sources += [
- "codecs/isac/fix/source/lattice_armv7.S",
- "codecs/isac/fix/source/pitch_filter_armv6.S",
- ]
sources -= [
"codecs/isac/fix/source/lattice_c.c",
"codecs/isac/fix/source/pitch_filter_c.c",
]
+ deps += [ ":isac_fix_c_asm" ]
}
if (current_cpu == "mipsel") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine