Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2973463003: Override bots to use libstdc++ on Linux (Closed)

Created:
3 years, 5 months ago by oprypin_webrtc
Modified:
3 years, 5 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Override bots to use libstdc++ on Linux BUG=webrtc:7922 Review-Url: https://codereview.webrtc.org/2973463003 Cr-Commit-Position: refs/heads/master@{#18890} Committed: https://chromium.googlesource.com/external/webrtc/+/f612998fa0500bd11c88aaa0710bf6dc09409d87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M tools_webrtc/mb/mb_config.pyl View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
oprypin_webrtc
3 years, 5 months ago (2017-07-04 12:32:13 UTC) #5
ehmaldonado_webrtc
On 2017/07/04 12:32:13, oprypin_webrtc wrote: lgtm
3 years, 5 months ago (2017-07-04 12:35:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2973463003/1
3 years, 5 months ago (2017-07-04 12:38:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/f612998fa0500bd11c88aaa0710bf6dc09409d87
3 years, 5 months ago (2017-07-04 12:41:53 UTC) #13
oprypin_webrtc
3 years, 5 months ago (2017-07-14 07:04:47 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2980033003/ by oprypin@webrtc.org.

The reason for reverting is: libc++ breakage fixed upstream.

Powered by Google App Engine
This is Rietveld 408576698