Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2972743003:
Improves WebRTC.Audio.AveragePlayoutCallbacksBetweenGlitches UMA stat (Closed)
|
Created:
3 years, 5 months ago by henrika_webrtc Modified:
3 years, 5 months ago Reviewers:
minyue-webrtc CC:
webrtc-reviews_webrtc.org Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionImproves WebRTC.Audio.AveragePlayoutCallbacksBetweenGlitches UMA stat
BUG=b/38018041
Review-Url: https://codereview.webrtc.org/2972743003
Cr-Commit-Position: refs/heads/master@{#18897}
Committed: https://chromium.googlesource.com/external/webrtc/+/070efc088e7171a8bccd86d074ef09eca6c29397
Patch Set 1 #
Total comments: 2
Patch Set 2 : Review feedback #Patch Set 3 : nit #Messages
Total messages: 19 (13 generated)
Description was changed from ========== Improves WebRTC.Audio.AveragePlayoutCallbacksBetweenGlitches UMA stat Improves WebRTC.Audio.AveragePlayoutCallbacksBetweenGlitches UMA stat BUG= ========== to ========== Improves WebRTC.Audio.AveragePlayoutCallbacksBetweenGlitches UMA stat BUG=b/38018041 ==========
henrika@webrtc.org changed reviewers: + minyue@webrtc.org
PTAL
https://codereview.webrtc.org/2972743003/diff/1/webrtc/modules/audio_device/i... File webrtc/modules/audio_device/ios/audio_device_ios.mm (right): https://codereview.webrtc.org/2972743003/diff/1/webrtc/modules/audio_device/i... webrtc/modules/audio_device/ios/audio_device_ios.mm:267: if (num_playout_callbacks_ > 0 && num_detected_playout_glitches_ > 0) { num_playout_callbacks_ > 0 is redundant if, by design, num_detected_playout_glitches_ <= num_playout_callbacks_ I'd add RTC_DCHECK_GE(num_playout_callbacks_, num_detected_playout_glitches_).
PTAL https://codereview.webrtc.org/2972743003/diff/1/webrtc/modules/audio_device/i... File webrtc/modules/audio_device/ios/audio_device_ios.mm (right): https://codereview.webrtc.org/2972743003/diff/1/webrtc/modules/audio_device/i... webrtc/modules/audio_device/ios/audio_device_ios.mm:267: if (num_playout_callbacks_ > 0 && num_detected_playout_glitches_ > 0) { On 2017/07/05 08:20:21, minyue-webrtc wrote: > num_playout_callbacks_ > 0 is redundant if, by design, > num_detected_playout_glitches_ <= num_playout_callbacks_ > > I'd add > RTC_DCHECK_GE(num_playout_callbacks_, num_detected_playout_glitches_). > Acknowledged.
The CQ bit was checked by henrika@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/21509) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/27036)
The CQ bit was checked by henrika@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by henrika@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499247088177610,
"parent_rev": "abee2d89cdfd3345ffafc269b99acf6709207b5b", "commit_rev":
"070efc088e7171a8bccd86d074ef09eca6c29397"}
Message was sent while issue was closed.
Description was changed from ========== Improves WebRTC.Audio.AveragePlayoutCallbacksBetweenGlitches UMA stat BUG=b/38018041 ========== to ========== Improves WebRTC.Audio.AveragePlayoutCallbacksBetweenGlitches UMA stat BUG=b/38018041 Review-Url: https://codereview.webrtc.org/2972743003 Cr-Commit-Position: refs/heads/master@{#18897} Committed: https://chromium.googlesource.com/external/webrtc/+/070efc088e7171a8bccd86d07... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/070efc088e7171a8bccd86d07... |
