Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2972613002: Revert of Add received audio and video call duration metrics based on packets. (Closed)

Created:
3 years, 5 months ago by saza WebRTC
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add received audio and video call duration metrics based on packets. (patchset #4 id:140001 of https://codereview.webrtc.org/2957073002/ ) Reason for revert: The following, seemingly related, unit tests crash on Android32 (M Nexus5X). org.webrtc.PeerConnectionTest#testCompleteSession org.webrtc.PeerConnectionTest#testDataChannelOnlySession A Windows build fails with a mysterious compile error. Original issue's description: > Add received audio/video call duration metrics based on packets. > > Tracks time between first and last audio and packets to successfully pass through Call object's DeliverRtp method, timed with packet timestamps. > > BUG=webrtc:7882 > > Review-Url: https://codereview.webrtc.org/2957073002 > Cr-Commit-Position: refs/heads/master@{#18881} > Committed: https://chromium.googlesource.com/external/webrtc/+/746749237ab5e34bd6bfa9cc0da63fffce528901 TBR=stefan@webrtc.org,aleloi@webrtc.org,asapersson@webrtc.org,holmer@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7882 Review-Url: https://codereview.webrtc.org/2972613002 Cr-Commit-Position: refs/heads/master@{#18882} Committed: https://chromium.googlesource.com/external/webrtc/+/382f21cd9c4e41229bc0f0a1e65017cbadd343e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M webrtc/call/call.cc View 4 chunks +0 lines, -24 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
saza WebRTC
Created Revert of Add received audio and video call duration metrics based on packets.
3 years, 5 months ago (2017-07-04 08:11:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2972613002/1
3 years, 5 months ago (2017-07-04 08:11:46 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 08:11:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/382f21cd9c4e41229bc0f0a1e...

Powered by Google App Engine
This is Rietveld 408576698