Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2972393002: Remove traces from {send,receive}_statistics_proxy.cc (Closed)

Created:
3 years, 5 months ago by ehmaldonado_webrtc
Modified:
3 years, 4 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove traces from {send,receive}_statistics_proxy.cc These traces will be traced instead when getStats() is called by JavaScript. BUG=chromium:653087 Review-Url: https://codereview.webrtc.org/2972393002 Cr-Commit-Position: refs/heads/master@{#19124} Committed: https://chromium.googlesource.com/external/webrtc/+/d083e851f66004b913459670a61cebbc801af53f

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove trace_event.h instead of logging.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M webrtc/video/receive_statistics_proxy.cc View 4 chunks +0 lines, -28 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 9 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
ehmaldonado_webrtc
3 years, 5 months ago (2017-07-10 15:44:46 UTC) #3
ehmaldonado_webrtc
3 years, 5 months ago (2017-07-10 16:05:16 UTC) #5
sprang_webrtc
lgtm with include fixed https://codereview.webrtc.org/2972393002/diff/1/webrtc/video/send_statistics_proxy.cc File webrtc/video/send_statistics_proxy.cc (left): https://codereview.webrtc.org/2972393002/diff/1/webrtc/video/send_statistics_proxy.cc#oldcode21 webrtc/video/send_statistics_proxy.cc:21: #include "webrtc/rtc_base/logging.h" I think you ...
3 years, 5 months ago (2017-07-24 14:28:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2972393002/20001
3 years, 5 months ago (2017-07-24 14:58:23 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2017-07-24 16:00:23 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/d083e851f66004b913459670a...

Powered by Google App Engine
This is Rietveld 408576698