Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2971613003: Adds support for USB audio devices in AppRTCMobile on Android (Closed)

Created:
3 years, 5 months ago by henrika_webrtc
Modified:
3 years, 5 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adds support for USB audio devices in AppRTCMobile on Android. This change extends the definition of wired headset to also include USB devices. The effect is that audio will now be routed to USB audio devices when used in combination with AppRTCMobile. BUG=webrtc:7931 Review-Url: https://codereview.webrtc.org/2971613003 Cr-Commit-Position: refs/heads/master@{#18889} Committed: https://chromium.googlesource.com/external/webrtc/+/8eadead3f42f4cf8a1265bb31ec74114a58662aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java View 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
henrika_webrtc
PTAL
3 years, 5 months ago (2017-07-04 11:17:47 UTC) #4
henrika_webrtc
Small change but large effect ;-)
3 years, 5 months ago (2017-07-04 11:18:10 UTC) #5
magjed_webrtc
lgtm
3 years, 5 months ago (2017-07-04 11:22:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2971613003/1
3 years, 5 months ago (2017-07-04 11:24:56 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 12:10:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8eadead3f42f4cf8a1265bb31...

Powered by Google App Engine
This is Rietveld 408576698