Add a check in the BlockBuffer of AEC2 to guard for buffer overflows.

Add a check in the BlockBuffer of AEC2 to guard for buffer overflows.

Ensure that the ring buffer does not return a pointer into the buffer if
no data is available to read.

The ring buffer fix is not directly applicable to issue webrtc:7845, but may cause related memory errors.

BUG=webrtc:7845
Review-Url: https://codereview.webrtc.org/2971313002
Cr-Commit-Position: refs/heads/master@{#18940}
Committed: https://chromium.googlesource.com/external/webrtc/+/5de068082bcb95c45efd476183a3773a939291b7

[saza WebRTC, 2017-07-07 14:01:29]

Patchset #2 (id:20001) has been deleted

[saza WebRTC, 2017-07-07 14:01:49]

Patchset #1 (id:1) has been deleted

[saza WebRTC, 2017-07-07 14:17:56]

Description was changed from

==========
Add a check in the BlockBuffer of AEC2 to guard for buffer overflows.
Ensure that the ring buffer does not return a pointer into its array if
no elements can be read.

BUG=7845
==========

to

==========
Add a check in the BlockBuffer of AEC2 to guard for buffer overflows.

Ensure that the ring buffer does not return a pointer into the buffer if
no data is available to read.

The ring buffer fix is not directly applicable to issue webrtc:7845, but may
cause related memory errors.

BUG=webrtc:7845
==========

[saza WebRTC, 2017-07-07 14:17:56]

saza@webrtc.org changed reviewers:
+ kwiberg@webrtc.org, peah@webrtc.org

[saza WebRTC, 2017-07-07 14:17:56]

saza@webrtc.org changed required reviewers:
+ kwiberg@webrtc.org, peah@webrtc.org

[saza WebRTC, 2017-07-07 14:19:39]

ptal

kwiberg@, ptal. You are listed as owner of webrtc/common_audio/.

[peah-webrtc, 2017-07-07 14:28:24]

On 2017/07/07 14:19:39, Sam Zackrisson WebRTC wrote:
> ptal
> 
> kwiberg@, ptal. You are listed as owner of webrtc/common_audio/.

Nice!
lgtm with one comment.

[peah-webrtc, 2017-07-07 14:28:56]

https://codereview.webrtc.org/2971313002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core.cc (right):

https://codereview.webrtc.org/2971313002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.cc:205: size_t read_elements;
I think you should move the declaration to line 210 where it is first used.

[saza WebRTC, 2017-07-10 06:47:50]

The CQ bit was checked by saza@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-10 06:47:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[saza WebRTC, 2017-07-10 06:53:15]

saza@webrtc.org changed reviewers:
+ jan.skoglund@webrtc.org
- kwiberg@webrtc.org

[saza WebRTC, 2017-07-10 06:53:15]

saza@webrtc.org changed required reviewers:
+ jan.skoglund@webrtc.org
- kwiberg@webrtc.org

[saza WebRTC, 2017-07-10 06:53:16]

https://codereview.webrtc.org/2971313002/diff/40001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/aec/aec_core.cc (right):

https://codereview.webrtc.org/2971313002/diff/40001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/aec/aec_core.cc:205: size_t read_elements;
On 2017/07/07 14:28:56, peah-webrtc wrote:
> I think you should move the declaration to line 210 where it is first used.

Done.

[saza WebRTC, 2017-07-10 07:03:44]

saza@webrtc.org changed required reviewers:
- peah@webrtc.org

[saza WebRTC, 2017-07-10 07:03:45]

PTAL

[saza WebRTC, 2017-07-10 07:05:09]

On 2017/07/07 14:19:39, Sam Zackrisson WebRTC wrote:
> ptal
> 
> kwiberg@, ptal. You are listed as owner of webrtc/common_audio/.

My vacation-checking game is off. Added jks as owner-reviewer instead.

[jks, 2017-07-10 07:29:19]

lgtm

[saza WebRTC, 2017-07-10 07:30:48]

The CQ bit was checked by saza@webrtc.org

[saza WebRTC, 2017-07-10 07:30:49]

The patchset sent to the CQ was uploaded after l-g-t-m from peah@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2971313002/#ps60001 (title:
"Move declaration of variable to point of first use.")

[commit-bot: I haz the power, 2017-07-10 07:30:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-10 08:01:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499671848284080,
"parent_rev": "3ffa72d0f03b75812c0ce367c1958ff9a80a6aeb", "commit_rev":
"5de068082bcb95c45efd476183a3773a939291b7"}

[commit-bot: I haz the power, 2017-07-10 08:01:17]

Description was changed from

==========
Add a check in the BlockBuffer of AEC2 to guard for buffer overflows.

Ensure that the ring buffer does not return a pointer into the buffer if
no data is available to read.

The ring buffer fix is not directly applicable to issue webrtc:7845, but may
cause related memory errors.

BUG=webrtc:7845
==========

to

==========
Add a check in the BlockBuffer of AEC2 to guard for buffer overflows.

Ensure that the ring buffer does not return a pointer into the buffer if
no data is available to read.

The ring buffer fix is not directly applicable to issue webrtc:7845, but may
cause related memory errors.

BUG=webrtc:7845

Review-Url: https://codereview.webrtc.org/2971313002
Cr-Commit-Position: refs/heads/master@{#18940}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5de068082bcb95c45efd47618...
==========

[commit-bot: I haz the power, 2017-07-10 08:01:18]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/5de068082bcb95c45efd47618...