Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2970923002:
vp8_impl.cc: Make it possible to base postproc deblocking level for arm on qp. (Closed)
|
Created:
3 years, 5 months ago by åsapersson Modified:
3 years, 4 months ago Reviewers:
brandtr CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
Descriptionvp8_impl.cc: Make it possible to base postproc deblocking level for arm on qp (e.g. turn off deblocking for low qp values).
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2970923002
Cr-Commit-Position: refs/heads/master@{#19300}
Committed: https://chromium.googlesource.com/external/webrtc/+/e5d02f9204c32a0faba4d844ddf60de0604b4c90
Patch Set 1 #Patch Set 2 : base level on qp instead of bitrate #Patch Set 3 #Patch Set 4 : rename #
Total comments: 8
Patch Set 5 #Patch Set 6 : address comments #
Messages
Total messages: 33 (28 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #2 (id:60001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:80001) has been deleted
Patchset #1 (id:100001) has been deleted
Patchset #1 (id:120001) has been deleted
Description was changed from ========== Make deblocking level depend on bitrate. Turn off deblocking for higher bitrates. BUG=webrtc:6634 ========== to ========== Make deblocking level depend on bitrate. Turn off deblocking for higher bitrates. BUG=webrtc:6634 ==========
asapersson@webrtc.org changed reviewers: + brandtr@webrtc.org
Description was changed from ========== Make deblocking level depend on bitrate. Turn off deblocking for higher bitrates. BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Make postproc deblocking level for arm depend on bitrate. Turn off deblocking for higher bitrates. BUG=webrtc:6634 ==========
Patchset #2 (id:160001) has been deleted
Patchset #2 (id:180001) has been deleted
Description was changed from ========== vp8_impl.cc: Make postproc deblocking level for arm depend on bitrate. Turn off deblocking for higher bitrates. BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Make postproc deblocking level for arm depend on qp. Make it possible to turn off deblocking for low qp values. BUG=webrtc:6634 ==========
Description was changed from ========== vp8_impl.cc: Make postproc deblocking level for arm depend on qp. Make it possible to turn off deblocking for low qp values. BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Make postproc deblocking level for arm dependent on qp. Make it possible to turn off deblocking for low qp values. BUG=webrtc:6634 ==========
Description was changed from ========== vp8_impl.cc: Make postproc deblocking level for arm dependent on qp. Make it possible to turn off deblocking for low qp values. BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Make it possible to base postproc deblocking level for arm on qp (e.g. turn off deblocking for low qp values). BUG=webrtc:6634 ==========
Description was changed from ========== vp8_impl.cc: Make it possible to base postproc deblocking level for arm on qp (e.g. turn off deblocking for low qp values). BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Make it possible to base postproc deblocking level for arm on qp (e.g. turn off deblocking for low qp values). BUG=webrtc:6634 ==========
Description was changed from ========== vp8_impl.cc: Make it possible to base postproc deblocking level for arm on qp (e.g. turn off deblocking for low qp values). BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Make it possible to base postproc deblocking level for arm on qp (e.g. turn off deblocking for low qp values). BUG=webrtc:6634 ==========
Patchset #4 (id:240001) has been deleted
Patchset #5 (id:280001) has been deleted
lgtm https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:146: } nit: newline. https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1056: int qp = qp_->GetAvg(); Just to be safe, maybe add a RTC_DCHECK(qp_). https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... File webrtc/modules/video_coding/codecs/vp8/vp8_impl.h (right): https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/vp8_impl.h:139: int level = 6; // Deblocking strength: [0, 16] Maybe name this |max_level| ? nit: period at end of comment. https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/vp8_impl.h:162: const std::unique_ptr<QpSmoother> qp_; |qp_smoother_| ?
Patchset #6 (id:320001) has been deleted
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... File webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc (right): https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:146: } On 2017/08/09 10:50:39, brandtr wrote: > nit: newline. Done. https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1056: int qp = qp_->GetAvg(); On 2017/08/09 10:50:39, brandtr wrote: > Just to be safe, maybe add a RTC_DCHECK(qp_). Done. https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... File webrtc/modules/video_coding/codecs/vp8/vp8_impl.h (right): https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/vp8_impl.h:139: int level = 6; // Deblocking strength: [0, 16] On 2017/08/09 10:50:39, brandtr wrote: > Maybe name this |max_level| ? > > nit: period at end of comment. Done. https://codereview.webrtc.org/2970923002/diff/260001/webrtc/modules/video_cod... webrtc/modules/video_coding/codecs/vp8/vp8_impl.h:162: const std::unique_ptr<QpSmoother> qp_; On 2017/08/09 10:50:39, brandtr wrote: > |qp_smoother_| ? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org Link to the patchset: https://codereview.webrtc.org/2970923002/#ps340001 (title: "address comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 340001, "attempt_start_ts": 1502346849564290,
"parent_rev": "44d8f569595bddec731a9402b3dae13ca4d5aa60", "commit_rev":
"e5d02f9204c32a0faba4d844ddf60de0604b4c90"}
Message was sent while issue was closed.
Description was changed from ========== vp8_impl.cc: Make it possible to base postproc deblocking level for arm on qp (e.g. turn off deblocking for low qp values). BUG=webrtc:6634 ========== to ========== vp8_impl.cc: Make it possible to base postproc deblocking level for arm on qp (e.g. turn off deblocking for low qp values). BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2970923002 Cr-Commit-Position: refs/heads/master@{#19300} Committed: https://chromium.googlesource.com/external/webrtc/+/e5d02f9204c32a0faba4d844d... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:340001) as https://chromium.googlesource.com/external/webrtc/+/e5d02f9204c32a0faba4d844d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
