Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2970793003: Reland of Add received audio/video call duration metrics based on packets. (Closed)

Created:
3 years, 5 months ago by saza WebRTC
Modified:
3 years, 5 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add received audio/video call duration metrics based on packets. Original issue: https://codereview.webrtc.org/2957073002/ Reason for reland: Failed Android unit tests and failed Windows compile. The tests seemed related at the time, but not after more consideration. Tracks time between first and last audio and packets to successfully pass through Call object's DeliverRtp method, timed with packet timestamps. BUG=webrtc:7882 TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2970793003 Cr-Commit-Position: refs/heads/master@{#18886} Committed: https://chromium.googlesource.com/external/webrtc/+/0d7f04daa0ddc621a7e3d6a0373b3ae458511030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M webrtc/call/call.cc View 4 chunks +24 lines, -0 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2970793003/1
3 years, 5 months ago (2017-07-04 11:02:45 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 11:05:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/0d7f04daa0ddc621a7e3d6a03...

Powered by Google App Engine
This is Rietveld 408576698