Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 5 months ago by ehmaldonado_webrtc Modified:
3 years, 5 months ago Reviewers:
mbonadei, kwiberg-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove webrtc/tools
BUG=webrtc:7855
TBR=kwiberg@webrtc.org
Review-Url: https://codereview.webrtc.org/2970743003
Cr-Commit-Position: refs/heads/master@{#18883}
Committed: https://chromium.googlesource.com/external/webrtc/+/ed56680adbfe3cbdd0744260f2e4c300439bf361
Patch Set 1 #
Created: 3 years, 5 months ago
Messages
Total messages: 22 (12 generated)
Description was changed from ========== Stuff BUG= ========== to ========== Stuff BUG= ==========
Description was changed from ========== Stuff BUG= ========== to ========== Remove webrtc/tools BUG= ==========
On 2017/07/03 15:42:38, ehmaldonado_webrtc wrote: lgtm. I am thinking at a possible bug... chromium:611808 should be good.
Description was changed from ========== Remove webrtc/tools BUG= ========== to ========== Remove webrtc/tools BUG=chromium:611808 ==========
ehmaldonado@webrtc.org changed reviewers: + mbonadei@webrtc.org
Description was changed from ========== Remove webrtc/tools BUG=chromium:611808 ========== to ========== Remove webrtc/tools BUG=webrtc:7855 ==========
On 2017/07/03 15:45:17, mbonadei wrote: > On 2017/07/03 15:42:38, ehmaldonado_webrtc wrote: > > lgtm. I am thinking at a possible bug... chromium:611808 should be good. I think webrtc:7855 is the one. :)
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18858)
ehmaldonado@webrtc.org changed reviewers: + kwiberg@webrtc.org
On 2017/07/03 16:13:52, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18858) Karl: Can you take a look, please?
Description was changed from ========== Remove webrtc/tools BUG=webrtc:7855 ========== to ========== Remove webrtc/tools BUG=webrtc:7855 TBR=kwiberg@webrtc.org ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1499157070012500, "parent_rev":
"382f21cd9c4e41229bc0f0a1e65017cbadd343e9", "commit_rev":
"ed56680adbfe3cbdd0744260f2e4c300439bf361"}
Message was sent while issue was closed.
Description was changed from ========== Remove webrtc/tools BUG=webrtc:7855 TBR=kwiberg@webrtc.org ========== to ========== Remove webrtc/tools BUG=webrtc:7855 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2970743003 Cr-Commit-Position: refs/heads/master@{#18883} Committed: https://chromium.googlesource.com/external/webrtc/+/ed56680adbfe3cbdd0744260f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/ed56680adbfe3cbdd0744260f...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2973493002/ by ehmaldonado@webrtc.org. The reason for reverting is: This should wait until https://chromium-review.googlesource.com/c/558980/ is submitted.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
