Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2970513002: Update PRESUBMIT.py for webrtc/{tools => rtc_tools} rename. (Closed)

Created:
3 years, 5 months ago by kjellander_webrtc
Modified:
3 years, 5 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update PRESUBMIT.py for webrtc/{tools => rtc_tools} rename. In https://codereview.webrtc.org/2965593002/ the directory was changed but presubmits were bypassed. BUG=webrtc:7855 NOTRY=True NOPRESUBMIT=True TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2970513002 Cr-Commit-Position: refs/heads/master@{#18851} Committed: https://chromium.googlesource.com/external/webrtc/+/41bafb2f2dc373c4db9b7c4431a8fa88c9daf1f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2970513002/1
3 years, 5 months ago (2017-06-30 11:05:01 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18744)
3 years, 5 months ago (2017-06-30 11:10:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2970513002/1
3 years, 5 months ago (2017-06-30 11:14:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/41bafb2f2dc373c4db9b7c4431a8fa88c9daf1f4
3 years, 5 months ago (2017-06-30 11:15:00 UTC) #11
kjellander_webrtc
+jansson: can you fix video_analysis.py? I have to run so I don't have time
3 years, 5 months ago (2017-06-30 11:15:25 UTC) #12
kwiberg-webrtc
lgtm
3 years, 5 months ago (2017-06-30 11:21:45 UTC) #13
janssonWebRTC
3 years, 5 months ago (2017-06-30 11:52:54 UTC) #14
Message was sent while issue was closed.
On 2017/06/30 11:15:25, kjellander_webrtc wrote:
> +jansson: can you fix video_analysis.py? I have to run so I don't have time

Done in https://codereview.webrtc.org/2966743002/

Powered by Google App Engine
This is Rietveld 408576698