Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2969943002: Improved low-level echo handling in echo canceller 3 (Closed)

Created:
3 years, 5 months ago by peah-webrtc
Modified:
3 years, 5 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Improved low-level echo handling in echo canceller 3 This CL addresses the issue of echo leakage of low level echoes by making the echo canceller more restrictive for that scenario. BUG=webrtc:7930 Review-Url: https://codereview.webrtc.org/2969943002 Cr-Commit-Position: refs/heads/master@{#18884} Committed: https://chromium.googlesource.com/external/webrtc/+/d3588cfb31089b1a1a7efd5df210b87929c8375c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/audio_processing/aec3/suppression_gain.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
peah-webrtc
Hi ivoc@ Could you please take a look at this CL?
3 years, 5 months ago (2017-07-04 05:24:32 UTC) #3
ivoc
lgtm.
3 years, 5 months ago (2017-07-04 08:31:43 UTC) #4
peah-webrtc
Thanks for the review!
3 years, 5 months ago (2017-07-04 08:32:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2969943002/1
3 years, 5 months ago (2017-07-04 08:32:47 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 08:54:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d3588cfb31089b1a1a7efd5df...

Powered by Google App Engine
This is Rietveld 408576698