Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2969863002: Only append SPS/PPS to bitstream if supplied out of band. (Closed)

Created:
3 years, 5 months ago by philipel
Modified:
3 years, 5 months ago
Reviewers:
holmer, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/branch-heads/60
Project:
webrtc
Visibility:
Public.

Description

Only append SPS/PPS to bitstream if supplied out of band. BUG=chromium:721597 R=holmer@google.com, stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2945853002 Cr-Original-Commit-Position: refs/heads/master@{#18701} Review-Url: https://codereview.webrtc.org/2969863002 . Cr-Commit-Position: refs/branch-heads/60@{#6} Cr-Branched-From: c61bf947b4ac31f3500858ffcae6fee39d799930-refs/heads/master@{#18252} Committed: https://chromium.googlesource.com/external/webrtc/+/5bcbe1f6c496cf1d1f9dcc3a1c39ac0f302f17ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -89 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/include/h264_globals.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/h264_sps_pps_tracker.cc View 4 chunks +38 lines, -56 lines 0 comments Download
M webrtc/modules/video_coding/h264_sps_pps_tracker_unittest.cc View 6 chunks +5 lines, -18 lines 0 comments Download
M webrtc/video/rtp_stream_receiver_unittest.cc View 5 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
philipel
Merge to M60, PTAL.
3 years, 5 months ago (2017-07-03 09:44:19 UTC) #2
holmer
lgtm
3 years, 5 months ago (2017-07-03 09:45:48 UTC) #4
stefan-webrtc
lgtm
3 years, 5 months ago (2017-07-03 13:09:58 UTC) #5
philipel
3 years, 5 months ago (2017-07-03 13:10:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5bcbe1f6c496cf1d1f9dcc3a1c39ac0f302f17ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698