Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2969543002: Remove libsrtp 2.0.0 compatibility code. (Closed)

Created:
3 years, 5 months ago by joachim
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove libsrtp 2.0.0 compatibility code. The upgrade to libsrtp 2.1.0 rolled in https://codereview.webrtc.org/2968463002 so the compatibility code can be removed. BUG=webrtc:7856 Review-Url: https://codereview.webrtc.org/2969543002 Cr-Commit-Position: refs/heads/master@{#19174} Committed: https://chromium.googlesource.com/external/webrtc/+/4c27a967671a93c9bb0f445c25d6e493bf81f17c

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M webrtc/pc/srtpsession.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
joachim
3 years, 5 months ago (2017-06-29 21:31:01 UTC) #2
Taylor Brandstetter
lgtm
3 years, 5 months ago (2017-06-30 07:44:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2969543002/1
3 years, 5 months ago (2017-06-30 07:44:33 UTC) #5
Taylor Brandstetter
Actually, wait before submitting this; I need to ensure internal projects won't break
3 years, 5 months ago (2017-06-30 07:47:50 UTC) #7
joachim
On 2017/06/30 07:47:50, Taylor Brandstetter wrote: > Actually, wait before submitting this; I need to ...
3 years, 5 months ago (2017-06-30 08:09:42 UTC) #8
joachim
On 2017/06/30 07:47:50, Taylor Brandstetter wrote: > Actually, wait before submitting this; I need to ...
3 years, 5 months ago (2017-07-24 22:24:22 UTC) #9
Taylor Brandstetter
On 2017/07/24 22:24:22, joachim wrote: > On 2017/06/30 07:47:50, Taylor Brandstetter wrote: > > Actually, ...
3 years, 5 months ago (2017-07-25 00:05:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2969543002/1
3 years, 4 months ago (2017-07-26 22:45:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/6394) ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 4 months ago (2017-07-26 22:47:09 UTC) #14
Taylor Brandstetter
Should be ready to submit now, but needs to be rebased.
3 years, 4 months ago (2017-07-26 23:02:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2969543002/20001
3 years, 4 months ago (2017-07-27 19:46:07 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/builds/6304)
3 years, 4 months ago (2017-07-27 20:08:07 UTC) #20
joachim
On 2017/07/27 20:08:07, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 4 months ago (2017-07-27 20:19:03 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2969543002/20001
3 years, 4 months ago (2017-07-27 22:02:08 UTC) #23
commit-bot: I haz the power
3 years, 4 months ago (2017-07-27 22:04:28 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/4c27a967671a93c9bb0f445c2...

Powered by Google App Engine
This is Rietveld 408576698