|
|
Chromium Code Reviews|
Created:
3 years, 5 months ago by joachim Modified:
3 years, 4 months ago Reviewers:
Taylor Brandstetter CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove libsrtp 2.0.0 compatibility code.
The upgrade to libsrtp 2.1.0 rolled in https://codereview.webrtc.org/2968463002
so the compatibility code can be removed.
BUG=webrtc:7856
Review-Url: https://codereview.webrtc.org/2969543002
Cr-Commit-Position: refs/heads/master@{#19174}
Committed: https://chromium.googlesource.com/external/webrtc/+/4c27a967671a93c9bb0f445c25d6e493bf81f17c
Patch Set 1 #Patch Set 2 : Rebased. #Messages
Total messages: 26 (11 generated)
jbauch@webrtc.org changed reviewers: + deadbeef@webrtc.org
lgtm
The CQ bit was checked by deadbeef@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by deadbeef@webrtc.org
Actually, wait before submitting this; I need to ensure internal projects won't break
On 2017/06/30 07:47:50, Taylor Brandstetter wrote: > Actually, wait before submitting this; I need to ensure internal projects won't > break Sure, no problem. Feel free to CQ whenever you are ready.
On 2017/06/30 07:47:50, Taylor Brandstetter wrote: > Actually, wait before submitting this; I need to ensure internal projects won't > break Ping, just checking back if this can land now.
On 2017/07/24 22:24:22, joachim wrote: > On 2017/06/30 07:47:50, Taylor Brandstetter wrote: > > Actually, wait before submitting this; I need to ensure internal projects > won't > > break > > Ping, just checking back if this can land now. Not yet, but getting closer.
The CQ bit was checked by deadbeef@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...) ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...) ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/22098) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/27638) linux_more_configs on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_more_configs/buil...)
Should be ready to submit now, but needs to be rebased.
The CQ bit was checked by jbauch@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org Link to the patchset: https://codereview.webrtc.org/2969543002/#ps20001 (title: "Rebased.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
On 2017/07/27 20:08:07, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...) The errors look like some internal swarming problems. I'll wait a bit and try to resubmit to CQ later.
The CQ bit was checked by jbauch@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1501192919150390,
"parent_rev": "516711cde932d8fb819bb31aeebeb159e9cedda9", "commit_rev":
"4c27a967671a93c9bb0f445c25d6e493bf81f17c"}
Message was sent while issue was closed.
Description was changed from ========== Remove libsrtp 2.0.0 compatibility code. The upgrade to libsrtp 2.1.0 rolled in https://codereview.webrtc.org/2968463002 so the compatibility code can be removed. BUG=webrtc:7856 ========== to ========== Remove libsrtp 2.0.0 compatibility code. The upgrade to libsrtp 2.1.0 rolled in https://codereview.webrtc.org/2968463002 so the compatibility code can be removed. BUG=webrtc:7856 Review-Url: https://codereview.webrtc.org/2969543002 Cr-Commit-Position: refs/heads/master@{#19174} Committed: https://chromium.googlesource.com/external/webrtc/+/4c27a967671a93c9bb0f445c2... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/4c27a967671a93c9bb0f445c2... |
