Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: webrtc/voice_engine/voe_base_impl.h

Issue 2969213002: External APM usage downstream dependency support cleanup (Closed)
Patch Set: Changes in response to reviewer commments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/voice_engine/include/voe_base.h ('k') | webrtc/voice_engine/voe_base_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/voe_base_impl.h
diff --git a/webrtc/voice_engine/voe_base_impl.h b/webrtc/voice_engine/voe_base_impl.h
index 6d7a086926e041d447f96e9cb804b95ca45964b3..0f3b023762047796b92fca80637991dd26c030e5 100644
--- a/webrtc/voice_engine/voe_base_impl.h
+++ b/webrtc/voice_engine/voe_base_impl.h
@@ -30,14 +30,8 @@ class VoEBaseImpl : public VoEBase,
int Init(
AudioDeviceModule* external_adm,
- AudioProcessing* external_apm,
+ AudioProcessing* audio_processing,
const rtc::scoped_refptr<AudioDecoderFactory>& decoder_factory) override;
- AudioProcessing* audio_processing() override {
- // TODO(peah): Remove this when downstream dependencies have properly been
- // resolved.
- RTC_DCHECK(audio_processing_);
- return audio_processing_.get();
- }
AudioDeviceModule* audio_device_module() override {
return shared_->audio_device();
}
@@ -124,10 +118,6 @@ class VoEBaseImpl : public VoEBase,
rtc::CriticalSection callbackCritSect_;
rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_;
- // TODO(peah): Remove this when upstream dependencies have properly been
- // resolved.
- rtc::scoped_refptr<AudioProcessing> audio_processing_;
-
AudioFrame audioFrame_;
voe::SharedData* shared_;
};
« no previous file with comments | « webrtc/voice_engine/include/voe_base.h ('k') | webrtc/voice_engine/voe_base_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698