Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2968683002:
Fix android video_quality_loopback_test (Closed)
|
Created:
3 years, 5 months ago by ehmaldonado_webrtc Modified:
3 years, 5 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix android video_quality_loopback_test
NOTRY=True
TBR=kjellander@webrtc.org
BUG=webrtc:7855
Review-Url: https://codereview.webrtc.org/2968683002
Cr-Commit-Position: refs/heads/master@{#18854}
Committed: https://chromium.googlesource.com/external/webrtc/+/3aba2d1af9c242553567099cb68c216cdb2209a8
Patch Set 1 #Patch Set 2 : Fix presubmit. #
Messages
Total messages: 28 (16 generated)
Description was changed from ========== stuff ========== to ========== Fix android video_quality_loopback_test ==========
ehmaldonado@webrtc.org changed reviewers: + kjellander@webrtc.org, mbonadei@webrtc.org
On 2017/06/30 11:41:49, ehmaldonado_webrtc wrote: lgtm
Description was changed from ========== Fix android video_quality_loopback_test ========== to ========== Fix android video_quality_loopback_test NOTRY=True ==========
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18750)
Description was changed from ========== Fix android video_quality_loopback_test NOTRY=True ========== to ========== Fix android video_quality_loopback_test NOTRY=True TDR=kjellander@webrtc.org ==========
Description was changed from ========== Fix android video_quality_loopback_test NOTRY=True TDR=kjellander@webrtc.org ========== to ========== Fix android video_quality_loopback_test NOTRY=True TBR=kjellander@webrtc.org ==========
The CQ bit was checked by ehmaldonado@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from mbonadei@webrtc.org Link to the patchset: https://codereview.webrtc.org/2968683002/#ps20001 (title: "Fix presubmit.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18753)
The CQ bit was checked by kjellander@webrtc.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Fix android video_quality_loopback_test NOTRY=True TBR=kjellander@webrtc.org ========== to ========== Fix android video_quality_loopback_test NOTRY=True TBR=kjellander@webrtc.org BUG=webrtc:7855 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18757)
On 2017/06/30 12:07:58, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18757) Was missing BUG= field.
The CQ bit was checked by ehmaldonado@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498824534633300,
"parent_rev": "d76b75370c11379cb77808ce92f13e5de6c34cba", "commit_rev":
"3aba2d1af9c242553567099cb68c216cdb2209a8"}
Message was sent while issue was closed.
Description was changed from ========== Fix android video_quality_loopback_test NOTRY=True TBR=kjellander@webrtc.org BUG=webrtc:7855 ========== to ========== Fix android video_quality_loopback_test NOTRY=True TBR=kjellander@webrtc.org BUG=webrtc:7855 Review-Url: https://codereview.webrtc.org/2968683002 Cr-Commit-Position: refs/heads/master@{#18854} Committed: https://chromium.googlesource.com/external/webrtc/+/3aba2d1af9c242553567099cb... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/3aba2d1af9c242553567099cb... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
