Stop silently accepting unsupported flags in test binaries

tools_webrtc/valgrind/webrtc_tests.py

Index: tools_webrtc/valgrind/webrtc_tests.py
diff --git a/tools_webrtc/valgrind/webrtc_tests.py b/tools_webrtc/valgrind/webrtc_tests.py
index 627025cd75d2413aaf688bf943c2d5dcda08af62..1921745e48e93f3aa1b98943f6b56d7890113253 100755
--- a/tools_webrtc/valgrind/webrtc_tests.py
+++ b/tools_webrtc/valgrind/webrtc_tests.py
@@ -24,6 +24,7 @@ Chrome's suppression files and our own, so we can easily maintain WebRTC
 specific suppressions in our own files.
 """
 
+import argparse
 import logging
 import optparse
 import os
@@ -124,6 +125,14 @@ def main(_):
                     help="run the tests with --test-launcher-shard-index")
   options, args = parser.parse_args()
 
+  ignore_parser = argparse.ArgumentParser()
+  # Ignore Chromium-specific flags
+  ignore_parser.add_argument('--isolated-script-test-output',
+                             type=str, default=None)
+  ignore_parser.add_argument('--isolated-script-test-chartjson-output',
+                             type=str, default=None)
+  _, args = ignore_parser.parse_known_args(args)

[kjellander_webrtc, 2017/08/18 12:49:52]

Just to check - these are needed since the memcheck bot isn't using
tools_webrtc/gtest-parallel-wrapper.py, right?

I'm leaning towards that we should work on getting rid of the flags being
specified in the first place (due to the bot using runtest.py and the Chromium
recipe modules), but we can punt that for the future for now if you add a
reference to a cleanup bug here.

[oprypin_webrtc, 2017/08/18 13:30:28]

I think so -- see patch set 1 where memcheck failed -- but it was a month ago :p
OK added reference

+
   if options.verbose:
     logging_utils.config_root(logging.DEBUG)
   else: