tools_webrtc/gtest-parallel-wrapper.py - Issue 2968003003: Stop silently accepting unsupported flags in test binaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools_webrtc/gtest-parallel-wrapper.py

Issue 2968003003: Stop silently accepting unsupported flags in test binaries (Closed)

Patch Set: Ignore flags passed by xcodebuild Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools_webrtc/gtest-parallel-wrapper.py

diff --git a/tools_webrtc/gtest-parallel-wrapper.py b/tools_webrtc/gtest-parallel-wrapper.py

index e7a659f2861cf01b499e9673316f6fe2414c09f4..19c8eb98a4f8fb076709fc7e3d97ea7daaa15b4f 100755

--- a/tools_webrtc/gtest-parallel-wrapper.py

+++ b/tools_webrtc/gtest-parallel-wrapper.py

@@ -81,6 +81,9 @@ def get_args_and_env():

parser.add_argument('--isolated-script-test-chartjson-output', type=str,

default=None)

+ # No-sandbox is a Chromium-specific flag, ignore it.

+ parser.add_argument('--no-sandbox', action='store_true', default=False)

# We have to do this, since --isolated-script-test-output is passed as an

# argument to the executable by the swarming scripts, and we want to pass it

# to gtest-parallel instead.