Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2967853002:
Remove unused static VideoEncoder functions (Closed)
|
Created:
3 years, 5 months ago by magjed_webrtc Modified:
3 years, 5 months ago CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, kwiberg-webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove unused static VideoEncoder functions
BUG=None
TBR=stefan
Review-Url: https://codereview.webrtc.org/2967853002
Cr-Commit-Position: refs/heads/master@{#18891}
Committed: https://chromium.googlesource.com/external/webrtc/+/cc8856c9c29509d5c814495f61f489651a4c9f91
Patch Set 1 #
Messages
Total messages: 20 (13 generated)
The CQ bit was checked by magjed@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Remove unused static VideoEncoder functions BUG=None ========== to ========== Remove unused static VideoEncoder functions BUG=None ==========
magjed@webrtc.org changed reviewers: + stefan@webrtc.org
Stefan - please take a look.
holmer@google.com changed reviewers: + holmer@google.com
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
Stefan - please stamp from your WebRTC account.
Description was changed from ========== Remove unused static VideoEncoder functions BUG=None ========== to ========== Remove unused static VideoEncoder functions BUG=None TBR=stefan ==========
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1499170869366820, "parent_rev":
"f612998fa0500bd11c88aaa0710bf6dc09409d87", "commit_rev":
"cc8856c9c29509d5c814495f61f489651a4c9f91"}
Message was sent while issue was closed.
Description was changed from ========== Remove unused static VideoEncoder functions BUG=None TBR=stefan ========== to ========== Remove unused static VideoEncoder functions BUG=None TBR=stefan Review-Url: https://codereview.webrtc.org/2967853002 Cr-Commit-Position: refs/heads/master@{#18891} Committed: https://chromium.googlesource.com/external/webrtc/+/cc8856c9c29509d5c814495f6... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/cc8856c9c29509d5c814495f6... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
