Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2967693002: Add RTC_FROM_HERE location information to two DCHECKs in ProcessThread. (Closed)

Created:
3 years, 5 months ago by tommi
Modified:
3 years, 4 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add RTC_FROM_HERE location information to two DCHECKs in ProcessThread. BUG=none TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/2967693002 Cr-Commit-Position: refs/heads/master@{#18937} Committed: https://chromium.googlesource.com/external/webrtc/+/cf39dd5d82a565f1ec5fd45453208adf4ee01407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M webrtc/modules/utility/source/process_thread_impl.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tommi
3 years, 5 months ago (2017-06-30 18:38:05 UTC) #2
tommi
tbr-ing for slightly more informational DCHECKs
3 years, 5 months ago (2017-07-07 22:46:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2967693002/1
3 years, 5 months ago (2017-07-07 22:47:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/cf39dd5d82a565f1ec5fd45453208adf4ee01407
3 years, 5 months ago (2017-07-07 23:24:41 UTC) #13
kwiberg-webrtc
3 years, 4 months ago (2017-07-31 08:05:31 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698