Added the ability to adjust the AEC3 performance for large rooms

Added the ability to adjust the AEC3 performance for large rooms

This CL exposes the parameter for adjusting the AEC3 performance
for large rooms.

Bug: webrtc:7519
Review-Url: https://codereview.webrtc.org/2967603002
Cr-Commit-Position: refs/heads/master@{#18862}
Committed: https://chromium.googlesource.com/external/webrtc/+/697a5903148af9da80d815212387563eac4c5052

[peah-webrtc, 2017-06-30 10:20:22]

peah@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[peah-webrtc, 2017-06-30 10:20:23]

Hi ivoc@
Could you please take a look at this CL?

[ivoc, 2017-06-30 11:40:03]

Looks mostly good, just a few questions.

https://codereview.webrtc.org/2967603002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec3/block_processor.cc (right):

https://codereview.webrtc.org/2967603002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec3/block_processor.cc:60: const
AudioProcessing::Config::EchoCanceller3& config,
This argument is not currently used here, why is it added? Will it be used in
the future?

https://codereview.webrtc.org/2967603002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec3/echo_canceller3.cc (right):

https://codereview.webrtc.org/2967603002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec3/echo_canceller3.cc:213: const
AudioProcessing::Config::EchoCanceller3& config,
This argument is also not used, Is it needed?

[peah-webrtc, 2017-06-30 13:20:16]

Thanks for the comments! I have addressed them in a new patch. PTAL

https://codereview.webrtc.org/2967603002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec3/block_processor.cc (right):

https://codereview.webrtc.org/2967603002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec3/block_processor.cc:60: const
AudioProcessing::Config::EchoCanceller3& config,
On 2017/06/30 11:40:03, ivoc wrote:
> This argument is not currently used here, why is it added? Will it be used in
> the future?

No, you are totally right. I did not realize that. Good point and find! I
removed it.

Done.

https://codereview.webrtc.org/2967603002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/aec3/echo_canceller3.cc (right):

https://codereview.webrtc.org/2967603002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/aec3/echo_canceller3.cc:213: const
AudioProcessing::Config::EchoCanceller3& config,
On 2017/06/30 11:40:03, ivoc wrote:
> This argument is also not used, Is it needed?

No, you are totally right. Good point and find!

Done.

[peah-webrtc, 2017-06-30 13:20:45]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 13:20:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ivoc, 2017-06-30 13:52:50]

lgtm!

[peah-webrtc, 2017-06-30 13:57:33]

The CQ bit was unchecked by peah@webrtc.org

[peah-webrtc, 2017-06-30 13:57:34]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2017-06-30 13:57:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-30 14:06:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498831054208810,
"parent_rev": "4583db49670c4c5e64f71ec35a56d9384849b13f", "commit_rev":
"697a5903148af9da80d815212387563eac4c5052"}

[commit-bot: I haz the power, 2017-06-30 14:06:16]

Description was changed from

==========
Added the ability to adjust the AEC3 performance for large rooms

This CL exposes the parameter for adjusting the AEC3 performance
for large rooms.

Bug:webrtc:7519
==========

to

==========
Added the ability to adjust the AEC3 performance for large rooms

This CL exposes the parameter for adjusting the AEC3 performance
for large rooms.

Bug: webrtc:7519
Review-Url: https://codereview.webrtc.org/2967603002
Cr-Commit-Position: refs/heads/master@{#18862}
Committed:
https://chromium.googlesource.com/external/webrtc/+/697a5903148af9da80d815212...
==========

[commit-bot: I haz the power, 2017-06-30 14:06:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/697a5903148af9da80d815212...