Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2966963002: Fix gmock warnings emanating from FlexfecReceiveStreamTest (Closed)

Created:
3 years, 5 months ago by eladalon
Modified:
3 years, 5 months ago
Reviewers:
brandtr, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman, danilchap, nisse-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix gmock warnings emanating from FlexfecReceiveStreamTest BUG=None Review-Url: https://codereview.webrtc.org/2966963002 Cr-Commit-Position: refs/heads/master@{#18878} Committed: https://chromium.googlesource.com/external/webrtc/+/7ab7fd66c44d8001899bb75de5aebb1b6e326b94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M webrtc/call/flexfec_receive_stream_unittest.cc View 7 chunks +25 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
eladalon
I'm not sure if it would be better to just NiceMock<> the process_thread_, or if ...
3 years, 5 months ago (2017-07-03 12:54:41 UTC) #3
stefan-webrtc
lgtm
3 years, 5 months ago (2017-07-03 13:08:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2966963002/1
3 years, 5 months ago (2017-07-03 13:35:02 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 13:57:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7ab7fd66c44d8001899bb75de...

Powered by Google App Engine
This is Rietveld 408576698