A few simplifications to CodecDatabase and VCMGenericDecoder

A few simplifications to CodecDatabase and VCMGenericDecoder.

* Remove the ReleaseDecoder and Release methods that were used in combination with deleting the decoder object. Now simply deleting the object does the right thing.
* Remove 'friend' relationship between the two classes since they don't need to touch each other's state directly anymore.
* Use std::unique_ptr for holding pointers and transferring ownership.

These changes were previously reviewed here:
https://codereview.webrtc.org/2764573002/

BUG=webrtc:7361, 695438
Review-Url: https://codereview.webrtc.org/2966823002
Cr-Commit-Position: refs/heads/master@{#18908}
Committed: https://chromium.googlesource.com/external/webrtc/+/5b7fc8ce424490ccf3229c855facdef78e6cb615

[tommi, 2017-06-30 17:40:53]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 17:40:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-30 17:46:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 17:46:27]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18786)

[tommi, 2017-06-30 17:46:55]

Description was changed from

==========
CodecDatabase refactor

BUG=
==========

to

==========
A few simplifications to CodecDatabase and VCMGenericDecoder.

* Remove the ReleaseDecoder and Release methods that were used in combination
with deleting the decoder object. Now simply deleting the object does the right
thing.
* Remove 'friend' relationship between the two classes since they don't need to
touch each other's state directly anymore.
* Use std::unique_ptr for holding pointers and transferring ownership.

BUG=
==========

[tommi, 2017-06-30 17:48:20]

Description was changed from

==========
A few simplifications to CodecDatabase and VCMGenericDecoder.

* Remove the ReleaseDecoder and Release methods that were used in combination
with deleting the decoder object. Now simply deleting the object does the right
thing.
* Remove 'friend' relationship between the two classes since they don't need to
touch each other's state directly anymore.
* Use std::unique_ptr for holding pointers and transferring ownership.

BUG=
==========

to

==========
A few simplifications to CodecDatabase and VCMGenericDecoder.

* Remove the ReleaseDecoder and Release methods that were used in combination
with deleting the decoder object. Now simply deleting the object does the right
thing.
* Remove 'friend' relationship between the two classes since they don't need to
touch each other's state directly anymore.
* Use std::unique_ptr for holding pointers and transferring ownership.

These changes were previously reviewed here:
https://codereview.webrtc.org/2764573002/

BUG=webrtc:7361, 695438
==========

[tommi, 2017-06-30 17:48:20]

tommi@webrtc.org changed reviewers:
+ sakal@webrtc.org

[tommi, 2017-06-30 17:51:01]

tommi@webrtc.org changed reviewers:
+ stefan@webrtc.org
- sakal@webrtc.org

[tommi, 2017-07-01 06:31:09]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-01 06:31:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-01 06:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-01 06:35:43]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18813)

[stefan-webrtc, 2017-07-05 09:44:15]

lgtm

[tommi, 2017-07-05 23:25:18]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2017-07-05 23:25:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-05 23:45:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499297118225460, "parent_rev":
"7025244bc09bdc530bf09454b6d25697a42d7674", "commit_rev":
"5b7fc8ce424490ccf3229c855facdef78e6cb615"}

[commit-bot: I haz the power, 2017-07-05 23:46:01]

Description was changed from

==========
A few simplifications to CodecDatabase and VCMGenericDecoder.

* Remove the ReleaseDecoder and Release methods that were used in combination
with deleting the decoder object. Now simply deleting the object does the right
thing.
* Remove 'friend' relationship between the two classes since they don't need to
touch each other's state directly anymore.
* Use std::unique_ptr for holding pointers and transferring ownership.

These changes were previously reviewed here:
https://codereview.webrtc.org/2764573002/

BUG=webrtc:7361, 695438
==========

to

==========
A few simplifications to CodecDatabase and VCMGenericDecoder.

* Remove the ReleaseDecoder and Release methods that were used in combination
with deleting the decoder object. Now simply deleting the object does the right
thing.
* Remove 'friend' relationship between the two classes since they don't need to
touch each other's state directly anymore.
* Use std::unique_ptr for holding pointers and transferring ownership.

These changes were previously reviewed here:
https://codereview.webrtc.org/2764573002/

BUG=webrtc:7361, 695438

Review-Url: https://codereview.webrtc.org/2966823002
Cr-Commit-Position: refs/heads/master@{#18908}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5b7fc8ce424490ccf3229c855...
==========

[commit-bot: I haz the power, 2017-07-05 23:46:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5b7fc8ce424490ccf3229c855...