Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2966503002:
Always ResetSenderCongestionControlObjects before RegisterEtc... (Closed)
|
Created:
3 years, 5 months ago by ossu Modified:
3 years, 5 months ago Reviewers:
minyue-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, tlegrand-webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAlways ResetSenderCongestionControlObjects before RegisterEtc...
BUG=webrtc:7896
Review-Url: https://codereview.webrtc.org/2966503002
Cr-Commit-Position: refs/heads/master@{#18844}
Committed: https://chromium.googlesource.com/external/webrtc/+/1129df26b0656512aaaf0430c4524c69bcde1346
Patch Set 1 #Patch Set 2 : Added a test to ensure Reset is called first. #
Messages
Total messages: 23 (17 generated)
The CQ bit was checked by ossu@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
ossu@webrtc.org changed reviewers: + minyue@chromium.org
Seems to be a simple fix: chose the wrong reason to reset congestion control objects before registering new ones.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ossu@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ossu@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by ossu@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Always ResetSenderCongestionControlObjects before RegisterEtc... BUG=webrtc:7896 ========== to ========== Always ResetSenderCongestionControlObjects before RegisterEtc... BUG=webrtc:7896 ==========
minyue@webrtc.org changed reviewers: + minyue@webrtc.org - minyue@chromium.org
The CQ bit was checked by minyue@webrtc.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498811788926540,
"parent_rev": "88af8b4b62bff1cc5ae24ef94a93f0406f0801cb", "commit_rev":
"1129df26b0656512aaaf0430c4524c69bcde1346"}
Message was sent while issue was closed.
Description was changed from ========== Always ResetSenderCongestionControlObjects before RegisterEtc... BUG=webrtc:7896 ========== to ========== Always ResetSenderCongestionControlObjects before RegisterEtc... BUG=webrtc:7896 Review-Url: https://codereview.webrtc.org/2966503002 Cr-Commit-Position: refs/heads/master@{#18844} Committed: https://chromium.googlesource.com/external/webrtc/+/1129df26b0656512aaaf0430c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/1129df26b0656512aaaf0430c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
