Enable the injection of an APM into a peerconnection

Enable the injection of an APM into a peerconnection

This CL finalizes the support for allowing an external
audio processing module to be used in a peerconnection.

BUG=webrtc:7775
Review-Url: https://codereview.webrtc.org/2965703002
Cr-Commit-Position: refs/heads/master@{#18864}
Committed: https://chromium.googlesource.com/external/webrtc/+/17675ceb131f561ee54607fd2547516c8bfb407e

[peah-webrtc, 2017-06-30 11:24:28]

Description was changed from

==========
Api Update

BUG=
==========

to

==========
Enable the injection of an APM into a peerconnection

This CL finalizes the support for allowing an external
audio processing module to be used in a peerconnection.

BUG=webrtc:7775
==========

[peah-webrtc, 2017-06-30 11:47:54]

Patchset #1 (id:1) has been deleted

[peah-webrtc, 2017-06-30 11:48:01]

Patchset #1 (id:20001) has been deleted

[peah-webrtc, 2017-06-30 11:48:08]

Patchset #1 (id:40001) has been deleted

[peah-webrtc, 2017-06-30 11:48:46]

peah@webrtc.org changed reviewers:
+ deadbeef@chromium.org

[peah-webrtc, 2017-06-30 11:48:47]

Hi Taylor,
Would you be able to review this CL?

https://codereview.webrtc.org/2965703002/diff/60001/webrtc/api/peerconnection...
File webrtc/api/peerconnectioninterface.h (right):

https://codereview.webrtc.org/2965703002/diff/60001/webrtc/api/peerconnection...
webrtc/api/peerconnectioninterface.h:1089:
rtc::scoped_refptr<PeerConnectionFactoryInterface> CreatePeerConnectionFactory(
This name was chosen in discussion with kwiberg@ as adding further suffixes
describing what modules were injected did not scale.

https://codereview.webrtc.org/2965703002/diff/60001/webrtc/pc/createpeerconne...
File webrtc/pc/createpeerconnectionfactory.cc (right):

https://codereview.webrtc.org/2965703002/diff/60001/webrtc/pc/createpeerconne...
webrtc/pc/createpeerconnectionfactory.cc:43:
rtc::scoped_refptr<PeerConnectionFactoryInterface> CreatePeerConnectionFactory(
This name was chosen in discussion with kwiberg@ as adding further suffixes
describing what modules were injected did not scale.

[peah-webrtc, 2017-06-30 11:51:51]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 11:52:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-30 12:29:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 12:29:03]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2017-06-30 14:18:39]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2017-06-30 14:18:39]

lgtm

https://codereview.webrtc.org/2965703002/diff/60001/webrtc/api/peerconnection...
File webrtc/api/peerconnectioninterface.h (right):

https://codereview.webrtc.org/2965703002/diff/60001/webrtc/api/peerconnection...
webrtc/api/peerconnectioninterface.h:1089:
rtc::scoped_refptr<PeerConnectionFactoryInterface> CreatePeerConnectionFactory(
On 2017/06/30 11:48:46, peah-webrtc wrote:
> This name was chosen in discussion with kwiberg@ as adding further suffixes
> describing what modules were injected did not scale.

Agreed. We touched on this is a "slim/modular webrtc" discussion yesterday, and
decided it's ok to keep adding more overloads, because eventually all the
modules should be represented here and the list will stop growing. And further
modularity will be provided by breaking individual modules apart (changing the
API for that module, but not necessarily for CreatePeerConnectionFactory).

[peah-webrtc, 2017-06-30 14:20:19]

peah@webrtc.org changed reviewers:
- deadbeef@chromium.org

[peah-webrtc, 2017-06-30 14:20:51]

Great! Thanks for the quick review!

[peah-webrtc, 2017-06-30 14:20:57]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2017-06-30 14:21:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-30 14:24:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498832457907230,
"parent_rev": "fa8567868ecaa869e976f780d799062fb1aee915", "commit_rev":
"17675ceb131f561ee54607fd2547516c8bfb407e"}

[commit-bot: I haz the power, 2017-06-30 14:24:08]

Description was changed from

==========
Enable the injection of an APM into a peerconnection

This CL finalizes the support for allowing an external
audio processing module to be used in a peerconnection.

BUG=webrtc:7775
==========

to

==========
Enable the injection of an APM into a peerconnection

This CL finalizes the support for allowing an external
audio processing module to be used in a peerconnection.

BUG=webrtc:7775

Review-Url: https://codereview.webrtc.org/2965703002
Cr-Commit-Position: refs/heads/master@{#18864}
Committed:
https://chromium.googlesource.com/external/webrtc/+/17675ceb131f561ee54607fd2...
==========

[commit-bot: I haz the power, 2017-06-30 14:24:10]

Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/17675ceb131f561ee54607fd2...