Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2965203002: Let NetEq reset the AudioFrame during muted state (Closed)

Created:
3 years, 5 months ago by hlundin-webrtc
Modified:
3 years, 5 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Let NetEq reset the AudioFrame during muted state In practice, this change will make AudioFrame::muted_ replicate the explicit muted variable, passed as a pointer to NetEq::GetAudio. BUG=webrtc:7944 Review-Url: https://codereview.webrtc.org/2965203002 Cr-Commit-Position: refs/heads/master@{#18914} Committed: https://chromium.googlesource.com/external/webrtc/+/a44910787b7b00543d08de8b518b1690cd6991b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hlundin-webrtc
PTAL
3 years, 5 months ago (2017-07-06 11:16:40 UTC) #2
minyue-webrtc
LG but how do you proceed with this? let it run a few days before ...
3 years, 5 months ago (2017-07-06 11:47:52 UTC) #3
hlundin-webrtc
On 2017/07/06 11:47:52, minyue-webrtc wrote: > LG but how do you proceed with this? let ...
3 years, 5 months ago (2017-07-06 11:53:19 UTC) #4
minyue-webrtc
lgtm
3 years, 5 months ago (2017-07-06 11:54:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2965203002/1
3 years, 5 months ago (2017-07-06 11:59:10 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 12:24:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a44910787b7b00543d08de8b5...

Powered by Google App Engine
This is Rietveld 408576698