Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2965193002:
Remove MAIN_NIB_FILE from Info.plist because the substitution is broken (Closed)
|
Created:
3 years, 5 months ago by oprypin_webrtc Modified:
3 years, 5 months ago CC:
webrtc-reviews_webrtc.org, andersc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove MAIN_NIB_FILE from Info.plist because the substitution is broken
BUG=webrtc:7943
Review-Url: https://codereview.webrtc.org/2965193002
Cr-Commit-Position: refs/heads/master@{#18915}
Committed: https://chromium.googlesource.com/external/webrtc/+/3b03476233b7ad8d338e904682d1594de4faa236
Patch Set 1 : Try with chromium roll #Patch Set 2 : Revert chromium roll #
Messages
Total messages: 22 (13 generated)
Description was changed from ========== Remove from Info.plist because the substitution is broken BUG=webrtc:7943 ========== to ========== Remove MAIN_NIB_FILE from Info.plist because the substitution is broken BUG=webrtc:7943 ==========
The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
oprypin@webrtc.org changed reviewers: + denicija@webrtc.org, henrika@webrtc.org
I'm removing this entry because the value it's trying to substitute is not present. I am not entirely sure that it's fine to do this. I checked that out/debug-ios/modules_unittests.app/Info.plist does not contain this entry even before this change, so I guess it's always been ignored anyway. See https://bugs.webrtc.org/7943 for context
I don't know these details well enough to comment. Daniela, can you review?
+andersc
On 2017/07/06 09:36:05, henrika_webrtc wrote: > I don't know these details well enough to comment. > > Daniela, can you review? It should be perfectly fine to remove this (the unit tests don't use NIB files anyhow). LGTM
The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by oprypin@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18951)
lgtm
The CQ bit was checked by oprypin@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499350024492990,
"parent_rev": "a44910787b7b00543d08de8b518b1690cd6991b2", "commit_rev":
"3b03476233b7ad8d338e904682d1594de4faa236"}
Message was sent while issue was closed.
Description was changed from ========== Remove MAIN_NIB_FILE from Info.plist because the substitution is broken BUG=webrtc:7943 ========== to ========== Remove MAIN_NIB_FILE from Info.plist because the substitution is broken BUG=webrtc:7943 Review-Url: https://codereview.webrtc.org/2965193002 Cr-Commit-Position: refs/heads/master@{#18915} Committed: https://chromium.googlesource.com/external/webrtc/+/3b03476233b7ad8d338e90468... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/3b03476233b7ad8d338e90468... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
