Report interframe delay sum in old GetStats

Report interframe delay sum in old GetStats

BUG=webrtc:7420
Review-Url: https://codereview.webrtc.org/2965033002
Cr-Commit-Position: refs/heads/master@{#18924}
Committed: https://chromium.googlesource.com/external/webrtc/+/f04afde85a9ce7f9ae6eba231b61362d2c94ccf7

[ilnik, 2017-07-05 14:22:12]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-05 14:22:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ilnik, 2017-07-05 14:39:32]

ilnik@webrtc.org changed reviewers:
+ sprang@webrtc.org

[commit-bot: I haz the power, 2017-07-05 15:12:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 15:12:12]

Dry run: This issue passed the CQ dry run.

[ilnik, 2017-07-06 08:09:42]

Description was changed from

==========
Report interframe delay sum in old GetStats

BUG=webrtc:7420
==========

to

==========
Report interframe delay sum in old GetStats

BUG=webrtc:7420
==========

[ilnik, 2017-07-06 08:09:42]

ilnik@webrtc.org changed reviewers:
+ magjed@webrtc.org, perkj@webrtc.org

[ilnik, 2017-07-06 08:11:53]

ilnik@webrtc.org changed reviewers:
+ stefan@webrtc.org
- magjed@webrtc.org, perkj@webrtc.org

[ilnik, 2017-07-06 08:12:37]

On 2017/07/05 14:39:32, ilnik wrote:

+stefan for api/ media/ pc/ and webrtc/video_receive_stream.h

[sprang_webrtc, 2017-07-06 09:16:28]

lgtm
thanks for fixing!

https://codereview.webrtc.org/2965033002/diff/1/webrtc/video/receive_statisti...
File webrtc/video/receive_statistics_proxy_unittest.cc (right):

https://codereview.webrtc.org/2965033002/diff/1/webrtc/video/receive_statisti...
webrtc/video/receive_statistics_proxy_unittest.cc:106:
VideoContentType::UNSPECIFIED);
nit: indentation

[ilnik, 2017-07-06 09:28:21]

The CQ bit was checked by ilnik@webrtc.org

[ilnik, 2017-07-06 09:28:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2965033002/#ps20001 (title:
"fix identation")

[commit-bot: I haz the power, 2017-07-06 09:28:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ilnik, 2017-07-06 09:28:58]

https://codereview.webrtc.org/2965033002/diff/1/webrtc/video/receive_statisti...
File webrtc/video/receive_statistics_proxy_unittest.cc (right):

https://codereview.webrtc.org/2965033002/diff/1/webrtc/video/receive_statisti...
webrtc/video/receive_statistics_proxy_unittest.cc:106:
VideoContentType::UNSPECIFIED);
On 2017/07/06 09:16:28, sprang_webrtc wrote:
> nit: indentation

Done.

[commit-bot: I haz the power, 2017-07-06 09:34:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 09:34:27]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/18939)

[stefan-webrtc, 2017-07-06 09:52:36]

stefan@webrtc.org changed reviewers:
+ hbos@webrtc.org

[stefan-webrtc, 2017-07-06 09:52:37]

+hbos since this is stats related.

lgtm from my side though.

https://codereview.webrtc.org/2965033002/diff/20001/webrtc/pc/statscollector.cc
File webrtc/pc/statscollector.cc (right):

https://codereview.webrtc.org/2965033002/diff/20001/webrtc/pc/statscollector....
webrtc/pc/statscollector.cc:254: info.interframe_delay_sum_ms);
git cl format?

[ilnik, 2017-07-06 09:54:30]

https://codereview.webrtc.org/2965033002/diff/20001/webrtc/pc/statscollector.cc
File webrtc/pc/statscollector.cc (right):

https://codereview.webrtc.org/2965033002/diff/20001/webrtc/pc/statscollector....
webrtc/pc/statscollector.cc:254: info.interframe_delay_sum_ms);
On 2017/07/06 09:52:37, stefan-webrtc wrote:
> git cl format?

Done.

[hbos, 2017-07-06 13:20:11]

This looks like something we could standardize? Can you propose it by filing a
bug at https://github.com/w3c/webrtc-stats/issues describing how it is
calculated?

lgtm

[hbos, 2017-07-06 13:21:38]

On 2017/07/06 13:20:11, hbos wrote:
> This looks like something we could standardize? Can you propose it by filing a
> bug at https://github.com/w3c/webrtc-stats/issues describing how it is
> calculated?
> 
> lgtm

What's the use case of this stat?

[ilnik, 2017-07-06 14:20:36]

On 2017/07/06 13:20:11, hbos wrote:
> This looks like something we could standardize? Can you propose it by filing a
> bug at https://github.com/w3c/webrtc-stats/issues describing how it is
> calculated?
> 
> lgtm

Yes, I will do that.

[ilnik, 2017-07-06 14:23:20]

On 2017/07/06 13:21:38, hbos wrote:
> On 2017/07/06 13:20:11, hbos wrote:
> > This looks like something we could standardize? Can you propose it by filing
a
> > bug at https://github.com/w3c/webrtc-stats/issues describing how it is
> > calculated?
> > 
> > lgtm
> 
> What's the use case of this stat?

We need it to measure lags on screenshare. In some sense, this metric is better
than e2e delay - e2e delay we can calculate only for the frames, which passed
through to the other side. Interframe delay will account for lots of lost frames
due to some death feedback loops, like we had for screenshare.

[ilnik, 2017-07-07 07:43:12]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 07:43:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-07 07:44:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 07:44:47]

Dry run: Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/21794)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/21580)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/27106)

[ilnik, 2017-07-07 08:00:17]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 08:00:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-07 08:22:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 08:22:39]

Dry run: This issue passed the CQ dry run.

[ilnik, 2017-07-07 08:23:14]

The CQ bit was checked by ilnik@webrtc.org

[ilnik, 2017-07-07 08:23:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org,
stefan@webrtc.org, hbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2965033002/#ps60001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-07-07 08:23:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-07 08:26:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499415794068210,
"parent_rev": "5b361730d0776fba4c6f1324a9dc1efcc148cdba", "commit_rev":
"f04afde85a9ce7f9ae6eba231b61362d2c94ccf7"}

[commit-bot: I haz the power, 2017-07-07 08:26:29]

Description was changed from

==========
Report interframe delay sum in old GetStats

BUG=webrtc:7420
==========

to

==========
Report interframe delay sum in old GetStats

BUG=webrtc:7420

Review-Url: https://codereview.webrtc.org/2965033002
Cr-Commit-Position: refs/heads/master@{#18924}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f04afde85a9ce7f9ae6eba231...
==========

[commit-bot: I haz the power, 2017-07-07 08:26:31]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/f04afde85a9ce7f9ae6eba231...