Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2964213002: Revert of Test and fix for huge bwe drop after alr state. (Closed)

Created:
3 years, 5 months ago by terelius
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, zhuangzesen_agora.io, tlegrand-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Test and fix for huge bwe drop after alr state. (patchset #13 id:320001 of https://codereview.webrtc.org/2931873002/ ) Reason for revert: Resetting the estimate means that we need to start gathering data from scratch again. The combination of 1) DelayBasedEstimator not reacting to overuse unless there is a valid estimate of the acknowledged bitrate, and 2) AcknowledgedBitrateEstimator needing a significant amount of time/data to obtain an provide an estimate causes poor performance in simulations/tests. It is not clear whether this will affect real networks negatively, but I suggest reverting this to be on the safe side. See also https://bugs.chromium.org/p/webrtc/issues/detail?id=7884 Original issue's description: > Test and fix for huge bwe drop after alr state. > > BUG=webrtc:7746 > > Review-Url: https://codereview.webrtc.org/2931873002 > Cr-Commit-Position: refs/heads/master@{#18692} > Committed: https://chromium.googlesource.com/external/webrtc/+/37aa8ba61641962119071646175bfe3bc2bda063 TBR=solenberg@webrtc.org,kwiberg@webrtc.org,minyue@webrtc.org,holmer@chromium.org,philipel@webrtc.org,oprypin@webrtc.org,holmer@google.com,stefan@webrtc.org,tschumim@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7746 Review-Url: https://codereview.webrtc.org/2964213002 Cr-Commit-Position: refs/heads/master@{#18866} Committed: https://chromium.googlesource.com/external/webrtc/+/e75d96b5bd3a952083b60efb860706845ce0dcb7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -714 lines) Patch
D resources/voice_engine/audio_dtx16.wav.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/audio/BUILD.gn View 3 chunks +0 lines, -39 lines 0 comments Download
D webrtc/audio/test/audio_bwe_integration_test.h View 1 chunk +0 lines, -53 lines 0 comments Download
D webrtc/audio/test/audio_bwe_integration_test.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M webrtc/modules/congestion_controller/BUILD.gn View 3 chunks +2 lines, -6 lines 0 comments Download
A webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.h View 1 chunk +48 lines, -0 lines 0 comments Download
A webrtc/modules/congestion_controller/acknowledge_bitrate_estimator.cc View 1 chunk +115 lines, -0 lines 0 comments Download
D webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.h View 1 chunk +0 lines, -55 lines 0 comments Download
D webrtc/modules/congestion_controller/acknowledged_bitrate_estimator.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D webrtc/modules/congestion_controller/acknowledged_bitrate_estimator_unittest.cc View 1 chunk +0 lines, -177 lines 0 comments Download
D webrtc/modules/congestion_controller/bitrate_estimator.h View 1 chunk +0 lines, -44 lines 0 comments Download
D webrtc/modules/congestion_controller/bitrate_estimator.cc View 1 chunk +0 lines, -101 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
terelius
Created Revert of Test and fix for huge bwe drop after alr state.
3 years, 5 months ago (2017-06-30 14:08:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2964213002/1
3 years, 5 months ago (2017-06-30 14:09:02 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 15:11:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e75d96b5bd3a952083b60efb8...

Powered by Google App Engine
This is Rietveld 408576698