Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2963673002: Disable some Opus tests pending an update (Closed)

Created:
3 years, 5 months ago by flim-webrtc
Modified:
3 years, 5 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable some Opus tests pending an update These tests will be reenabled and updated after Opus has been updated in Chromium and rolled into WebRTC. BUG=737323, webrtc:8024 Review-Url: https://codereview.webrtc.org/2963673002 Cr-Commit-Position: refs/heads/master@{#19118} Committed: https://chromium.googlesource.com/external/webrtc/+/bf8202185c40ba5bf1642098de64c5a06ccf3a46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest.cc View 12 chunks +13 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
flim-webrtc
Hi minyue, could you please take a look? Thanks!
3 years, 5 months ago (2017-06-28 01:15:36 UTC) #6
minyue-webrtc
lgtm
3 years, 5 months ago (2017-06-28 07:23:13 UTC) #7
flim-webrtc
On 2017/06/28 07:23:13, minyue-webrtc wrote: > lgtm Thanks! I'll land this when the related chromium ...
3 years, 5 months ago (2017-06-28 16:07:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2963673002/1
3 years, 5 months ago (2017-07-24 08:55:27 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-24 09:17:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/bf8202185c40ba5bf1642098d...

Powered by Google App Engine
This is Rietveld 408576698