Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2963543002: Fixing bad use of std::sort in test method. (Closed)

Created:
3 years, 5 months ago by Taylor Brandstetter
Modified:
3 years, 5 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing bad use of std::sort in test method. It was used to force a codec to the top of a list, but it resulted in "a < a" being true, which some C++ runtimes complain about. BUG=None TBR=pthatcher@webrtc.org Review-Url: https://codereview.webrtc.org/2963543002 Cr-Commit-Position: refs/heads/master@{#18786} Committed: https://chromium.googlesource.com/external/webrtc/+/8179a7cf97d1e05715f645ab98bb00999992fe8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M webrtc/ortc/testrtpparameters.cc View 2 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
Taylor Brandstetter
3 years, 5 months ago (2017-06-27 14:08:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2963543002/1
3 years, 5 months ago (2017-06-27 14:08:30 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 14:52:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8179a7cf97d1e05715f645ab9...

Powered by Google App Engine
This is Rietveld 408576698