Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 2963363002: Fix null ref in NetworkMonitorAutoDetect if Connectivity Manager service is unavailable (Closed)

Created:
3 years, 5 months ago by bdodson
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kbechtel_google.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix null ref in NetworkMonitorAutoDetect if Connectivity Manager service is unavailable BUG=webrtc:7917 TBR=magjed@webrtc.org Review-Url: https://codereview.webrtc.org/2963363002 Cr-Commit-Position: refs/heads/master@{#18906} Committed: https://chromium.googlesource.com/external/webrtc/+/6aa95117d8d6270d8ef4da8b33cbdd67b4043ba8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M webrtc/sdk/android/api/org/webrtc/NetworkMonitorAutoDetect.java View 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 15 (9 generated)
bdodson
3 years, 5 months ago (2017-06-30 20:37:14 UTC) #2
Zhi Huang
On 2017/06/30 20:37:14, bdodson wrote: LGTM. Taylor and I don't have power here. You might ...
3 years, 5 months ago (2017-06-30 20:51:10 UTC) #3
Taylor Brandstetter
lgtm
3 years, 5 months ago (2017-07-05 16:30:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2963363002/1
3 years, 5 months ago (2017-07-05 16:32:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/6aa95117d8d6270d8ef4da8b33cbdd67b4043ba8
3 years, 5 months ago (2017-07-05 16:55:16 UTC) #13
magjed_webrtc
3 years, 5 months ago (2017-07-07 11:49:07 UTC) #15
Message was sent while issue was closed.
https://codereview.webrtc.org/2963363002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/NetworkMonitorAutoDetect.java (right):

https://codereview.webrtc.org/2963363002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/NetworkMonitorAutoDetect.java:596: return
null;
Shouldn't we still add possible entries from wifiDirectManagerDelegate here?

Powered by Google App Engine
This is Rietveld 408576698