More gracefully handle rtp timestamp jumps in the rtp to ntp estimator.

More gracefully handle rtp timestamp jumps in the rtp to ntp estimator.

BUG=webrtc:7905
Review-Url: https://codereview.webrtc.org/2963133003
Cr-Commit-Position: refs/heads/master@{#18860}
Committed: https://chromium.googlesource.com/external/webrtc/+/1009cfca47a2e2765c375c4f8591125c1c222f23

[stefan-webrtc, 2017-06-30 09:31:52]

stefan@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[stefan-webrtc, 2017-06-30 09:36:24]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 09:36:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-30 09:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 09:58:41]

Dry run: This issue passed the CQ dry run.

[åsapersson, 2017-06-30 10:34:07]

https://codereview.webrtc.org/2963133003/diff/1/webrtc/system_wrappers/source...
File webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc (right):

https://codereview.webrtc.org/2963133003/diff/1/webrtc/system_wrappers/source...
webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc:130: if
(consecutive_old_timestamps_ < 3) {
maybe name the constant 3

https://codereview.webrtc.org/2963133003/diff/1/webrtc/system_wrappers/source...
webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc:132: << "Newer RTCP SR
report with older RTP timestamp, dropping";
Will log be correct if invalid_sample is set from line 114?

[stefan-webrtc, 2017-06-30 11:23:16]

Comments addressed.

[stefan-webrtc, 2017-06-30 11:25:28]

.

[stefan-webrtc, 2017-06-30 11:25:46]

https://codereview.webrtc.org/2963133003/diff/1/webrtc/system_wrappers/source...
File webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc (right):

https://codereview.webrtc.org/2963133003/diff/1/webrtc/system_wrappers/source...
webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc:130: if
(consecutive_old_timestamps_ < 3) {
On 2017/06/30 10:34:06, åsapersson wrote:
> maybe name the constant 3

Done.

https://codereview.webrtc.org/2963133003/diff/1/webrtc/system_wrappers/source...
webrtc/system_wrappers/source/rtp_to_ntp_estimator.cc:132: << "Newer RTCP SR
report with older RTP timestamp, dropping";
On 2017/06/30 10:34:06, åsapersson wrote:
> Will log be correct if invalid_sample is set from line 114?

No, good point.

[åsapersson, 2017-06-30 11:43:24]

lgtm

[stefan-webrtc, 2017-06-30 11:56:51]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2017-06-30 11:57:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-30 13:28:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498823811121160,
"parent_rev": "9addbebf427a8a49cd5a43cf4827c7c8b6e24c21", "commit_rev":
"1009cfca47a2e2765c375c4f8591125c1c222f23"}

[commit-bot: I haz the power, 2017-06-30 13:28:37]

Description was changed from

==========
More gracefully handle rtp timestamp jumps in the rtp to ntp estimator.

BUG=webrtc:7905
==========

to

==========
More gracefully handle rtp timestamp jumps in the rtp to ntp estimator.

BUG=webrtc:7905

Review-Url: https://codereview.webrtc.org/2963133003
Cr-Commit-Position: refs/heads/master@{#18860}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1009cfca47a2e2765c375c4f8...
==========

[commit-bot: I haz the power, 2017-06-30 13:28:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/1009cfca47a2e2765c375c4f8...