Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2962293002: Remove ProcessParams struct. (Closed)

Created:
3 years, 5 months ago by åsapersson
Modified:
3 years, 4 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove ProcessParams struct. Add SetProcessParams method for configuring process settings (removes intermediate step of configuring settings via ProcessParams). BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2962293002 Cr-Commit-Position: refs/heads/master@{#19206} Committed: https://chromium.googlesource.com/external/webrtc/+/8339e1a7aae74f1b49a3f1d3cae8cef190805ef7

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -180 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 1 4 chunks +19 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 13 chunks +52 lines, -81 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 14 chunks +70 lines, -85 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
åsapersson
3 years, 4 months ago (2017-07-28 07:18:51 UTC) #6
brandtr
lgtm
3 years, 4 months ago (2017-07-31 14:49:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2962293002/40001
3 years, 4 months ago (2017-08-02 07:14:38 UTC) #14
commit-bot: I haz the power
3 years, 4 months ago (2017-08-02 07:17:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/8339e1a7aae74f1b49a3f1d3c...

Powered by Google App Engine
This is Rietveld 408576698